Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cast to proper interface #124

Merged
merged 1 commit into from Jan 9, 2020
Merged

fix: cast to proper interface #124

merged 1 commit into from Jan 9, 2020

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Jan 9, 2020

Fixes #123

@codyoss codyoss requested a review from chingor13 Jan 9, 2020
@googlebot googlebot added the cla: yes label Jan 9, 2020
@codecov
Copy link

@codecov codecov bot commented Jan 9, 2020

Codecov Report

Merging #124 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #124      +/-   ##
============================================
- Coverage     66.32%   66.27%   -0.06%     
- Complexity      365      370       +5     
============================================
  Files            34       34              
  Lines          1877     1877              
  Branches        240      240              
============================================
- Hits           1245     1244       -1     
- Misses          530      531       +1     
  Partials        102      102
Impacted Files Coverage Δ Complexity Δ
...src/main/java/com/google/cloud/ServiceOptions.java 43.47% <100%> (-0.4%) 33 <0> (+1)
.../java/com/google/cloud/testing/CommandWrapper.java 87.87% <0%> (-9.1%) 13% <0%> (ø)
...a/com/google/cloud/testing/BaseEmulatorHelper.java 31.42% <0%> (+0.57%) 5% <0%> (ø) ⬇️
.../com/google/cloud/MonitoredResourceDescriptor.java 84.03% <0%> (+1.68%) 24% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01cbf1e...9fcb2ff. Read the comment docs.

@chingor13 chingor13 merged commit cd6eabf into googleapis:master Jan 9, 2020
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants