Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add google-cloud-core-bom artifact #13

Merged
merged 3 commits into from Sep 6, 2019

Conversation

chingor13
Copy link
Collaborator

@chingor13 chingor13 commented Sep 6, 2019

According to JLBP-15, all multi-module projects should produce a bom to keep versions in sync.

The google-cloud-bom can import this bom, rather than specifying the versions.

@googlebot googlebot added the cla: yes label Sep 6, 2019
@codecov
Copy link

@codecov codecov bot commented Sep 6, 2019

Codecov Report

Merging #13 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #13      +/-   ##
============================================
- Coverage     66.46%   66.43%   -0.04%     
- Complexity      362      367       +5     
============================================
  Files            34       34              
  Lines          1858     1865       +7     
  Branches        234      236       +2     
============================================
+ Hits           1235     1239       +4     
- Misses          521      524       +3     
  Partials        102      102
Impacted Files Coverage Δ Complexity Δ
...re/src/main/java/com/google/cloud/RetryHelper.java 50% <0%> (-3.85%) 2% <0%> (ø)
...src/main/java/com/google/cloud/ServiceOptions.java 41.73% <0%> (+0.06%) 30% <0%> (+1%) ⬆️
...a/com/google/cloud/testing/BaseEmulatorHelper.java 31.42% <0%> (+0.21%) 5% <0%> (ø) ⬇️
.../com/google/cloud/MonitoredResourceDescriptor.java 84.03% <0%> (+0.27%) 24% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e3ccf3...f9d14cf. Read the comment docs.

@chingor13 chingor13 requested a review from elharo Sep 6, 2019
elharo
elharo approved these changes Sep 6, 2019
<parent>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-shared-config</artifactId>
<version>0.1.0</version>
Copy link
Contributor

@elharo elharo Sep 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this version be synced with the rest of the repo?

Copy link
Collaborator Author

@chingor13 chingor13 Sep 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the version of the bom. The parent project is an external parent that contains the shared build/testing/release configuration across the split repositories.

@chingor13 chingor13 merged commit 3cb19a0 into googleapis:master Sep 6, 2019
10 checks passed
@chingor13 chingor13 deleted the add-bom branch Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants