Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix conversion for pre-epoch timestamps #160

Merged
merged 3 commits into from Feb 25, 2020
Merged

Conversation

chingor13
Copy link
Collaborator

@chingor13 chingor13 commented Feb 19, 2020

Fixes #159

@googlebot googlebot added the cla: yes label Feb 19, 2020
@codecov
Copy link

@codecov codecov bot commented Feb 19, 2020

Codecov Report

Merging #160 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #160      +/-   ##
============================================
+ Coverage     66.54%   66.56%   +0.01%     
- Complexity      370      371       +1     
============================================
  Files            34       34              
  Lines          1877     1881       +4     
  Branches        240      241       +1     
============================================
+ Hits           1249     1252       +3     
- Misses          526      527       +1     
  Partials        102      102
Impacted Files Coverage Δ Complexity Δ
...core/src/main/java/com/google/cloud/Timestamp.java 90.62% <100%> (+0.62%) 25 <2> (+1) ⬆️
.../java/com/google/cloud/testing/CommandWrapper.java 87.87% <0%> (-9.1%) 13% <0%> (ø)
...src/main/java/com/google/cloud/ServiceOptions.java 44.26% <0%> (+0.79%) 33% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebc0e6c...b17ac48. Read the comment docs.

@chingor13 chingor13 changed the title test: failing test for parsing a negative timestamp fix: fix conversion for pre-epoch timestamps Feb 19, 2020
@chingor13 chingor13 marked this pull request as ready for review Feb 19, 2020
@chingor13 chingor13 requested a review from Feb 19, 2020
Copy link
Contributor

@elharo elharo left a comment

also, haven't we seen this problem before a few months back? maybe in a different project?

@chingor13
Copy link
Collaborator Author

@chingor13 chingor13 commented Feb 19, 2020

also, haven't we seen this problem before a few months back? maybe in a different project?

I think this was something similar: googleapis/google-http-java-client#895

@chingor13 chingor13 merged commit 1f8b6b4 into master Feb 25, 2020
15 checks passed
@chingor13 chingor13 deleted the fix-negative-timestamp branch Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants