googleapis / java-core Public
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix conversion for pre-epoch timestamps #160
Conversation
0030226
to
0c32d16
Compare
Codecov Report
@@ Coverage Diff @@
## master #160 +/- ##
============================================
+ Coverage 66.54% 66.56% +0.01%
- Complexity 370 371 +1
============================================
Files 34 34
Lines 1877 1881 +4
Branches 240 241 +1
============================================
+ Hits 1249 1252 +3
- Misses 526 527 +1
Partials 102 102
Continue to review full report at Codecov.
|
google-cloud-core/src/test/java/com/google/cloud/TimestampTest.java
Outdated
Show resolved
Hide resolved
google-cloud-core/src/main/java/com/google/cloud/Timestamp.java
Outdated
Show resolved
Hide resolved
google-cloud-core/src/main/java/com/google/cloud/Timestamp.java
Outdated
Show resolved
Hide resolved
also, haven't we seen this problem before a few months back? maybe in a different project?
I think this was something similar: googleapis/google-http-java-client#895 |
🤖 I have created a release \*beep\* \*boop\* --- ## [1.93.0](https://www.github.com/googleapis/java-core/compare/v1.92.6...v1.93.0) (2020-02-27) ### Features * support conditional policies ([#110](https://www.github.com/googleapis/java-core/issues/110)) ([61e2d19](https://www.github.com/googleapis/java-core/commit/61e2d19bb4400978681aa018a8dc200214203830)) ### Bug Fixes * fix conversion for pre-epoch timestamps ([#160](https://www.github.com/googleapis/java-core/issues/160)) ([1f8b6b4](https://www.github.com/googleapis/java-core/commit/1f8b6b4835aaa702ec94bbbde89ed90f519c935a)) ### Dependencies * update dependency com.google.api:gax-bom to v1.54.0 ([#168](https://www.github.com/googleapis/java-core/issues/168)) ([5b52f9e](https://www.github.com/googleapis/java-core/commit/5b52f9e8d8cdc82b56114d3d1e857d137ae7ca98)) * update dependency io.grpc:grpc-bom to v1.27.2 ([#166](https://www.github.com/googleapis/java-core/issues/166)) ([28c9859](https://www.github.com/googleapis/java-core/commit/28c98595c9ee96760a063085bd85024177bd6dd2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Fixes #159