Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase DEFAULT_CHUNK_SIZE to reduce transfer overhead #87

Merged
merged 1 commit into from Dec 13, 2019

Conversation

domZippilli
Copy link
Contributor

@domZippilli domZippilli commented Dec 4, 2019

Fixes #86 by setting the DEFAULT_CHUNK_SIZE to 15MiB.

@googlebot googlebot added the cla: yes label Dec 4, 2019
@chingor13 chingor13 added the kokoro:force-run label Dec 4, 2019
@kokoro-team kokoro-team removed kokoro:force-run labels Dec 4, 2019
Copy link
Contributor

@elharo elharo left a comment

Looks like this breaks com.google.cloud.BaseWriteChannelTest

@domZippilli domZippilli force-pushed the master branch 2 times, most recently from 7303d92 to 6f0abcd Compare Dec 5, 2019
@codecov
Copy link

@codecov codecov bot commented Dec 5, 2019

Codecov Report

Merging #87 into master will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #87      +/-   ##
============================================
+ Coverage     66.32%   66.46%   +0.14%     
+ Complexity      367      362       -5     
============================================
  Files            34       34              
  Lines          1865     1858       -7     
  Branches        236      234       -2     
============================================
- Hits           1237     1235       -2     
+ Misses          526      521       -5     
  Partials        102      102
Impacted Files Coverage Δ Complexity Δ
...c/main/java/com/google/cloud/BaseWriteChannel.java 36.5% <ø> (ø) 18 <0> (ø) ⬇️
.../com/google/cloud/MonitoredResourceDescriptor.java 83.76% <0%> (-0.28%) 20% <0%> (-4%)
...a/com/google/cloud/testing/BaseEmulatorHelper.java 31.21% <0%> (-0.22%) 5% <0%> (ø)
...src/main/java/com/google/cloud/ServiceOptions.java 41.66% <0%> (+0.75%) 29% <0%> (-1%) ⬇️
...re/src/main/java/com/google/cloud/RetryHelper.java 53.84% <0%> (+3.84%) 2% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5128bd4...cd4f8ed. Read the comment docs.

frankyn
frankyn approved these changes Dec 5, 2019
Copy link
Member

@frankyn frankyn left a comment

LGTM. Thanks @domZippilli!

@domZippilli domZippilli requested a review from elharo Dec 5, 2019
@domZippilli
Copy link
Contributor Author

@domZippilli domZippilli commented Dec 12, 2019

Hey just wanted to check in -- are there any steps I need to take to move this forward?

elharo
elharo approved these changes Dec 12, 2019
Copy link
Contributor

@elharo elharo left a comment

@frankyn FYI, you need to select the approve button in Github. Unlike google3, LGTM in a comment doesn't suffice.

@frankyn
Copy link
Member

@frankyn frankyn commented Dec 12, 2019

I did approve, but my approval doesn't count IIUC. Also I can't merge, could you help merge the PR as well @elharo?

@elharo elharo merged commit 09b327d into googleapis:master Dec 13, 2019
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants