Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support setting ServiceOption for quota project #92

Merged
merged 7 commits into from Dec 13, 2019
Merged

feat: support setting ServiceOption for quota project #92

merged 7 commits into from Dec 13, 2019

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Dec 11, 2019

No description provided.

@googlebot googlebot added the cla: yes label Dec 11, 2019
@codyoss
Copy link
Member Author

@codyoss codyoss commented Dec 11, 2019

Before this can work two PRs need to be merged and their artifacts released:

Will update this PR after that happens

@codyoss codyoss added the do not merge label Dec 11, 2019
@codecov
Copy link

@codecov codecov bot commented Dec 13, 2019

Codecov Report

Merging #92 into master will increase coverage by 0.21%.
The diff coverage is 82.35%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #92      +/-   ##
============================================
+ Coverage     66.43%   66.64%   +0.21%     
- Complexity      367      370       +3     
============================================
  Files            34       34              
  Lines          1865     1877      +12     
  Branches        236      240       +4     
============================================
+ Hits           1239     1251      +12     
  Misses          524      524              
  Partials        102      102
Impacted Files Coverage Δ Complexity Δ
...va/com/google/cloud/http/HttpTransportOptions.java 56.94% <100%> (+0.6%) 10 <0> (ø) ⬇️
...src/main/java/com/google/cloud/ServiceOptions.java 44.26% <81.25%> (+2.53%) 33 <3> (+3) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b4df8f...f53a167. Read the comment docs.

@codyoss codyoss removed the do not merge label Dec 13, 2019
@codyoss codyoss marked this pull request as ready for review Dec 13, 2019
@codyoss codyoss requested a review from Dec 13, 2019
@codyoss codyoss requested a review from chingor13 Dec 13, 2019
Copy link
Collaborator

@chingor13 chingor13 left a comment

Small testing nit

@codyoss codyoss requested a review from chingor13 Dec 13, 2019
@codyoss codyoss merged commit 6aa4476 into googleapis:master Dec 13, 2019
13 checks passed
@codyoss codyoss deleted the quota-project branch Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants