feat: add order field to TagField and TagTemplateField message …

…in tags.proto (#166) fix: broken document links & polish comments feat: add csharp/ruby/PHP namespaces chore: update copyright for proto files PiperOrigin-RevId: 307068250 Source-Author: Google APIs <noreply@google.com> Source-Date: Fri Apr 17 10:26:08 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: b5e9b0b09cc15c263f07da92fa64db31b2e4dd07 Source-Link: googleapis/googleapis@b5e9b0b
googleapis · Apr 20, 2020 · ed46c97 · ed46c97
1 parent 7d5dd43
commit ed46c97
Show file tree

Hide file tree

Showing 51 changed files with 1,206 additions and 987 deletions.
diff --git a/...oud-datacatalog/src/main/java/com/google/cloud/datacatalog/v1beta1/DataCatalogClient.java b/...oud-datacatalog/src/main/java/com/google/cloud/datacatalog/v1beta1/DataCatalogClient.java
diff --git a/...datacatalog/src/test/java/com/google/cloud/datacatalog/v1beta1/DataCatalogClientTest.java b/...datacatalog/src/test/java/com/google/cloud/datacatalog/v1beta1/DataCatalogClientTest.java
@@ -905,11 +905,13 @@ public void createTagTemplateFieldTest() {
     String name = "name3373707";
     String displayName = "displayName1615086568";
     boolean isRequired = true;
+    int order = 106006350;
     TagTemplateField expectedResponse =
         TagTemplateField.newBuilder()
             .setName(name)
             .setDisplayName(displayName)
             .setIsRequired(isRequired)
+            .setOrder(order)
             .build();
     mockDataCatalog.addResponse(expectedResponse);
 
@@ -961,11 +963,13 @@ public void updateTagTemplateFieldTest() {
     String name2 = "name2-1052831874";
     String displayName = "displayName1615086568";
     boolean isRequired = true;
+    int order = 106006350;
     TagTemplateField expectedResponse =
         TagTemplateField.newBuilder()
             .setName(name2)
             .setDisplayName(displayName)
             .setIsRequired(isRequired)
+            .setOrder(order)
             .build();
     mockDataCatalog.addResponse(expectedResponse);
 
@@ -1017,11 +1021,13 @@ public void renameTagTemplateFieldTest() {
     String name2 = "name2-1052831874";
     String displayName = "displayName1615086568";
     boolean isRequired = true;
+    int order = 106006350;
     TagTemplateField expectedResponse =
         TagTemplateField.newBuilder()
             .setName(name2)
             .setDisplayName(displayName)
             .setIsRequired(isRequired)
+            .setOrder(order)
             .build();
     mockDataCatalog.addResponse(expectedResponse);
 

diff --git a/...tacatalog-v1beta1/src/main/java/com/google/cloud/datacatalog/v1beta1/DataCatalogGrpc.java b/...tacatalog-v1beta1/src/main/java/com/google/cloud/datacatalog/v1beta1/DataCatalogGrpc.java
diff --git a/...-cloud-datacatalog-v1beta1/src/main/java/com/google/cloud/datacatalog/v1beta1/Common.java b/...-cloud-datacatalog-v1beta1/src/main/java/com/google/cloud/datacatalog/v1beta1/Common.java
@@ -39,10 +39,13 @@ public static com.google.protobuf.Descriptors.FileDescriptor getDescriptor() {
           + "n.proto\022 google.cloud.datacatalog.v1beta"
           + "1*U\n\020IntegratedSystem\022!\n\035INTEGRATED_SYST"
           + "EM_UNSPECIFIED\020\000\022\014\n\010BIGQUERY\020\001\022\020\n\014CLOUD_"
-          + "PUBSUB\020\002Bx\n$com.google.cloud.datacatalog"
-          + ".v1beta1P\001ZKgoogle.golang.org/genproto/g"
-          + "oogleapis/cloud/datacatalog/v1beta1;data"
-          + "catalog\370\001\001b\006proto3"
+          + "PUBSUB\020\002B\344\001\n$com.google.cloud.datacatalo"
+          + "g.v1beta1P\001ZKgoogle.golang.org/genproto/"
+          + "googleapis/cloud/datacatalog/v1beta1;dat"
+          + "acatalog\370\001\001\252\002 Google.Cloud.DataCatalog.V"
+          + "1Beta1\312\002 Google\\Cloud\\DataCatalog\\V1beta"
+          + "1\352\002#Google::Cloud::DataCatalog::V1beta1b"
+          + "\006proto3"
     };
     descriptor =
         com.google.protobuf.Descriptors.FileDescriptor.internalBuildGeneratedFileFrom(

diff --git a/...acatalog-v1beta1/src/main/java/com/google/cloud/datacatalog/v1beta1/CreateTagRequest.java b/...acatalog-v1beta1/src/main/java/com/google/cloud/datacatalog/v1beta1/CreateTagRequest.java
@@ -134,8 +134,8 @@ public static final com.google.protobuf.Descriptors.Descriptor getDescriptor() {
    *
    *
    * <pre>
-   * Required. The name of the resource to attach this tag to. Tags can be
-   * attached to Entries. Example:
+   * Required. The name of the resource to attach this tag to. Tags can be attached to
+   * Entries. Example:
    * * projects/{project_id}/locations/{location}/entryGroups/{entry_group_id}/entries/{entry_id}
    * Note that this Tag and its child resources may not actually be stored in
    * the location in this name.
@@ -162,8 +162,8 @@ public java.lang.String getParent() {
    *
    *
    * <pre>
-   * Required. The name of the resource to attach this tag to. Tags can be
-   * attached to Entries. Example:
+   * Required. The name of the resource to attach this tag to. Tags can be attached to
+   * Entries. Example:
    * * projects/{project_id}/locations/{location}/entryGroups/{entry_group_id}/entries/{entry_id}
    * Note that this Tag and its child resources may not actually be stored in
    * the location in this name.
@@ -586,8 +586,8 @@ public Builder mergeFrom(
      *
      *
      * <pre>
-     * Required. The name of the resource to attach this tag to. Tags can be
-     * attached to Entries. Example:
+     * Required. The name of the resource to attach this tag to. Tags can be attached to
+     * Entries. Example:
      * * projects/{project_id}/locations/{location}/entryGroups/{entry_group_id}/entries/{entry_id}
      * Note that this Tag and its child resources may not actually be stored in
      * the location in this name.
@@ -614,8 +614,8 @@ public java.lang.String getParent() {
      *
      *
      * <pre>
-     * Required. The name of the resource to attach this tag to. Tags can be
-     * attached to Entries. Example:
+     * Required. The name of the resource to attach this tag to. Tags can be attached to
+     * Entries. Example:
      * * projects/{project_id}/locations/{location}/entryGroups/{entry_group_id}/entries/{entry_id}
      * Note that this Tag and its child resources may not actually be stored in
      * the location in this name.
@@ -642,8 +642,8 @@ public com.google.protobuf.ByteString getParentBytes() {
      *
      *
      * <pre>
-     * Required. The name of the resource to attach this tag to. Tags can be
-     * attached to Entries. Example:
+     * Required. The name of the resource to attach this tag to. Tags can be attached to
+     * Entries. Example:
      * * projects/{project_id}/locations/{location}/entryGroups/{entry_group_id}/entries/{entry_id}
      * Note that this Tag and its child resources may not actually be stored in
      * the location in this name.
@@ -669,8 +669,8 @@ public Builder setParent(java.lang.String value) {
      *
      *
      * <pre>
-     * Required. The name of the resource to attach this tag to. Tags can be
-     * attached to Entries. Example:
+     * Required. The name of the resource to attach this tag to. Tags can be attached to
+     * Entries. Example:
      * * projects/{project_id}/locations/{location}/entryGroups/{entry_group_id}/entries/{entry_id}
      * Note that this Tag and its child resources may not actually be stored in
      * the location in this name.
@@ -692,8 +692,8 @@ public Builder clearParent() {
      *
      *
      * <pre>
-     * Required. The name of the resource to attach this tag to. Tags can be
-     * attached to Entries. Example:
+     * Required. The name of the resource to attach this tag to. Tags can be attached to
+     * Entries. Example:
      * * projects/{project_id}/locations/{location}/entryGroups/{entry_group_id}/entries/{entry_id}
      * Note that this Tag and its child resources may not actually be stored in
      * the location in this name.

diff --git a/...v1beta1/src/main/java/com/google/cloud/datacatalog/v1beta1/CreateTagRequestOrBuilder.java b/...v1beta1/src/main/java/com/google/cloud/datacatalog/v1beta1/CreateTagRequestOrBuilder.java
@@ -27,8 +27,8 @@ public interface CreateTagRequestOrBuilder
    *
    *
    * <pre>
-   * Required. The name of the resource to attach this tag to. Tags can be
-   * attached to Entries. Example:
+   * Required. The name of the resource to attach this tag to. Tags can be attached to
+   * Entries. Example:
    * * projects/{project_id}/locations/{location}/entryGroups/{entry_group_id}/entries/{entry_id}
    * Note that this Tag and its child resources may not actually be stored in
    * the location in this name.
@@ -45,8 +45,8 @@ public interface CreateTagRequestOrBuilder
    *
    *
    * <pre>
-   * Required. The name of the resource to attach this tag to. Tags can be
-   * attached to Entries. Example:
+   * Required. The name of the resource to attach this tag to. Tags can be attached to
+   * Entries. Example:
    * * projects/{project_id}/locations/{location}/entryGroups/{entry_group_id}/entries/{entry_id}
    * Note that this Tag and its child resources may not actually be stored in
    * the location in this name.

diff --git a/...ta1/src/main/java/com/google/cloud/datacatalog/v1beta1/CreateTagTemplateFieldRequest.java b/...ta1/src/main/java/com/google/cloud/datacatalog/v1beta1/CreateTagTemplateFieldRequest.java
@@ -144,8 +144,7 @@ public static final com.google.protobuf.Descriptors.Descriptor getDescriptor() {
    *
    * <pre>
    * Required. The name of the project and the template location
-   * [region](/compute/docs/regions-zones/#available).
-   * NOTE: Currently, only the `us-central1 region` is supported.
+   * [region](https://cloud.google.com/data-catalog/docs/concepts/regions).
    * Example:
    * * projects/{project_id}/locations/us-central1/tagTemplates/{tag_template_id}
    * </pre>
@@ -172,8 +171,7 @@ public java.lang.String getParent() {
    *
    * <pre>
    * Required. The name of the project and the template location
-   * [region](/compute/docs/regions-zones/#available).
-   * NOTE: Currently, only the `us-central1 region` is supported.
+   * [region](https://cloud.google.com/data-catalog/docs/concepts/regions).
    * Example:
    * * projects/{project_id}/locations/us-central1/tagTemplates/{tag_template_id}
    * </pre>
@@ -681,8 +679,7 @@ public Builder mergeFrom(
      *
      * <pre>
      * Required. The name of the project and the template location
-     * [region](/compute/docs/regions-zones/#available).
-     * NOTE: Currently, only the `us-central1 region` is supported.
+     * [region](https://cloud.google.com/data-catalog/docs/concepts/regions).
      * Example:
      * * projects/{project_id}/locations/us-central1/tagTemplates/{tag_template_id}
      * </pre>
@@ -709,8 +706,7 @@ public java.lang.String getParent() {
      *
      * <pre>
      * Required. The name of the project and the template location
-     * [region](/compute/docs/regions-zones/#available).
-     * NOTE: Currently, only the `us-central1 region` is supported.
+     * [region](https://cloud.google.com/data-catalog/docs/concepts/regions).
      * Example:
      * * projects/{project_id}/locations/us-central1/tagTemplates/{tag_template_id}
      * </pre>
@@ -737,8 +733,7 @@ public com.google.protobuf.ByteString getParentBytes() {
      *
      * <pre>
      * Required. The name of the project and the template location
-     * [region](/compute/docs/regions-zones/#available).
-     * NOTE: Currently, only the `us-central1 region` is supported.
+     * [region](https://cloud.google.com/data-catalog/docs/concepts/regions).
      * Example:
      * * projects/{project_id}/locations/us-central1/tagTemplates/{tag_template_id}
      * </pre>
@@ -764,8 +759,7 @@ public Builder setParent(java.lang.String value) {
      *
      * <pre>
      * Required. The name of the project and the template location
-     * [region](/compute/docs/regions-zones/#available).
-     * NOTE: Currently, only the `us-central1 region` is supported.
+     * [region](https://cloud.google.com/data-catalog/docs/concepts/regions).
      * Example:
      * * projects/{project_id}/locations/us-central1/tagTemplates/{tag_template_id}
      * </pre>
@@ -787,8 +781,7 @@ public Builder clearParent() {
      *
      * <pre>
      * Required. The name of the project and the template location
-     * [region](/compute/docs/regions-zones/#available).
-     * NOTE: Currently, only the `us-central1 region` is supported.
+     * [region](https://cloud.google.com/data-catalog/docs/concepts/regions).
      * Example:
      * * projects/{project_id}/locations/us-central1/tagTemplates/{tag_template_id}
      * </pre>

diff --git a/...ain/java/com/google/cloud/datacatalog/v1beta1/CreateTagTemplateFieldRequestOrBuilder.java b/...ain/java/com/google/cloud/datacatalog/v1beta1/CreateTagTemplateFieldRequestOrBuilder.java
@@ -28,8 +28,7 @@ public interface CreateTagTemplateFieldRequestOrBuilder
    *
    * <pre>
    * Required. The name of the project and the template location
-   * [region](/compute/docs/regions-zones/#available).
-   * NOTE: Currently, only the `us-central1 region` is supported.
+   * [region](https://cloud.google.com/data-catalog/docs/concepts/regions).
    * Example:
    * * projects/{project_id}/locations/us-central1/tagTemplates/{tag_template_id}
    * </pre>
@@ -46,8 +45,7 @@ public interface CreateTagTemplateFieldRequestOrBuilder
    *
    * <pre>
    * Required. The name of the project and the template location
-   * [region](/compute/docs/regions-zones/#available).
-   * NOTE: Currently, only the `us-central1 region` is supported.
+   * [region](https://cloud.google.com/data-catalog/docs/concepts/regions).
    * Example:
    * * projects/{project_id}/locations/us-central1/tagTemplates/{tag_template_id}
    * </pre>

diff --git a/...-v1beta1/src/main/java/com/google/cloud/datacatalog/v1beta1/CreateTagTemplateRequest.java b/...-v1beta1/src/main/java/com/google/cloud/datacatalog/v1beta1/CreateTagTemplateRequest.java
@@ -143,8 +143,7 @@ public static final com.google.protobuf.Descriptors.Descriptor getDescriptor() {
    *
    * <pre>
    * Required. The name of the project and the template location
-   * [region](/compute/docs/regions-zones/#available).
-   * NOTE: Currently, only the `us-central1 region` is supported.
+   * [region](https://cloud.google.com/data-catalog/docs/concepts/regions.
    * Example:
    * * projects/{project_id}/locations/us-central1
    * </pre>
@@ -171,8 +170,7 @@ public java.lang.String getParent() {
    *
    * <pre>
    * Required. The name of the project and the template location
-   * [region](/compute/docs/regions-zones/#available).
-   * NOTE: Currently, only the `us-central1 region` is supported.
+   * [region](https://cloud.google.com/data-catalog/docs/concepts/regions.
    * Example:
    * * projects/{project_id}/locations/us-central1
    * </pre>
@@ -666,8 +664,7 @@ public Builder mergeFrom(
      *
      * <pre>
      * Required. The name of the project and the template location
-     * [region](/compute/docs/regions-zones/#available).
-     * NOTE: Currently, only the `us-central1 region` is supported.
+     * [region](https://cloud.google.com/data-catalog/docs/concepts/regions.
      * Example:
      * * projects/{project_id}/locations/us-central1
      * </pre>
@@ -694,8 +691,7 @@ public java.lang.String getParent() {
      *
      * <pre>
      * Required. The name of the project and the template location
-     * [region](/compute/docs/regions-zones/#available).
-     * NOTE: Currently, only the `us-central1 region` is supported.
+     * [region](https://cloud.google.com/data-catalog/docs/concepts/regions.
      * Example:
      * * projects/{project_id}/locations/us-central1
      * </pre>
@@ -722,8 +718,7 @@ public com.google.protobuf.ByteString getParentBytes() {
      *
      * <pre>
      * Required. The name of the project and the template location
-     * [region](/compute/docs/regions-zones/#available).
-     * NOTE: Currently, only the `us-central1 region` is supported.
+     * [region](https://cloud.google.com/data-catalog/docs/concepts/regions.
      * Example:
      * * projects/{project_id}/locations/us-central1
      * </pre>
@@ -749,8 +744,7 @@ public Builder setParent(java.lang.String value) {
      *
      * <pre>
      * Required. The name of the project and the template location
-     * [region](/compute/docs/regions-zones/#available).
-     * NOTE: Currently, only the `us-central1 region` is supported.
+     * [region](https://cloud.google.com/data-catalog/docs/concepts/regions.
      * Example:
      * * projects/{project_id}/locations/us-central1
      * </pre>
@@ -772,8 +766,7 @@ public Builder clearParent() {
      *
      * <pre>
      * Required. The name of the project and the template location
-     * [region](/compute/docs/regions-zones/#available).
-     * NOTE: Currently, only the `us-central1 region` is supported.
+     * [region](https://cloud.google.com/data-catalog/docs/concepts/regions.
      * Example:
      * * projects/{project_id}/locations/us-central1
      * </pre>

diff --git a/...src/main/java/com/google/cloud/datacatalog/v1beta1/CreateTagTemplateRequestOrBuilder.java b/...src/main/java/com/google/cloud/datacatalog/v1beta1/CreateTagTemplateRequestOrBuilder.java
@@ -28,8 +28,7 @@ public interface CreateTagTemplateRequestOrBuilder
    *
    * <pre>
    * Required. The name of the project and the template location
-   * [region](/compute/docs/regions-zones/#available).
-   * NOTE: Currently, only the `us-central1 region` is supported.
+   * [region](https://cloud.google.com/data-catalog/docs/concepts/regions.
    * Example:
    * * projects/{project_id}/locations/us-central1
    * </pre>
@@ -46,8 +45,7 @@ public interface CreateTagTemplateRequestOrBuilder
    *
    * <pre>
    * Required. The name of the project and the template location
-   * [region](/compute/docs/regions-zones/#available).
-   * NOTE: Currently, only the `us-central1 region` is supported.
+   * [region](https://cloud.google.com/data-catalog/docs/concepts/regions.
    * Example:
    * * projects/{project_id}/locations/us-central1
    * </pre>

diff --git a/...d-datacatalog-v1beta1/src/main/java/com/google/cloud/datacatalog/v1beta1/Datacatalog.java b/...d-datacatalog-v1beta1/src/main/java/com/google/cloud/datacatalog/v1beta1/Datacatalog.java
@@ -466,10 +466,13 @@ public static com.google.protobuf.Descriptors.FileDescriptor getDescriptor() {
           + "cts/*/locations/*/entryGroups/*/entries/"
           + "*}:testIamPermissions:\001*\032N\312A\032datacatalog"
           + ".googleapis.com\322A.https://www.googleapis"
-          + ".com/auth/cloud-platformBx\n$com.google.c"
-          + "loud.datacatalog.v1beta1P\001ZKgoogle.golan"
-          + "g.org/genproto/googleapis/cloud/datacata"
-          + "log/v1beta1;datacatalog\370\001\001b\006proto3"
+          + ".com/auth/cloud-platformB\344\001\n$com.google."
+          + "cloud.datacatalog.v1beta1P\001ZKgoogle.gola"
+          + "ng.org/genproto/googleapis/cloud/datacat"
+          + "alog/v1beta1;datacatalog\370\001\001\252\002 Google.Clo"
+          + "ud.DataCatalog.V1Beta1\312\002 Google\\Cloud\\Da"
+          + "taCatalog\\V1beta1\352\002#Google::Cloud::DataC"
+          + "atalog::V1beta1b\006proto3"
     };
     descriptor =
         com.google.protobuf.Descriptors.FileDescriptor.internalBuildGeneratedFileFrom(