Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v1): add v1 client #131

Merged
merged 1 commit into from Mar 31, 2020
Merged

feat(v1): add v1 client #131

merged 1 commit into from Mar 31, 2020

Conversation

chingor13
Copy link
Collaborator

@chingor13 chingor13 commented Mar 26, 2020

Towards #73

@chingor13 chingor13 requested a review from Mar 26, 2020
@googlebot googlebot added the cla: yes label Mar 26, 2020
@codecov
Copy link

@codecov codecov bot commented Mar 26, 2020

Codecov Report

Merging #131 into master will decrease coverage by 1.22%.
The diff coverage is 81.91%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #131      +/-   ##
============================================
- Coverage     79.96%   78.73%   -1.23%     
- Complexity      271      428     +157     
============================================
  Files            18       24       +6     
  Lines          2046     3400    +1354     
  Branches          5       10       +5     
============================================
+ Hits           1636     2677    +1041     
- Misses          405      693     +288     
- Partials          5       30      +25     
Impacted Files Coverage Δ Complexity Δ
...google/cloud/datacatalog/v1/DataCatalogClient.java 61.32% <ø> (ø) 82.00 <0.00> (?)
...gle/cloud/datacatalog/v1/stub/DataCatalogStub.java 3.12% <3.12%> (ø) 1.00 <1.00> (?)
...ogle/cloud/datacatalog/v1/DataCatalogSettings.java 8.64% <8.64%> (ø) 2.00 <2.00> (?)
...atalog/v1/stub/GrpcDataCatalogCallableFactory.java 37.50% <37.50%> (ø) 3.00 <3.00> (?)
...d/datacatalog/v1/stub/DataCatalogStubSettings.java 82.92% <82.92%> (ø) 36.00 <36.00> (?)
...cloud/datacatalog/v1/stub/GrpcDataCatalogStub.java 97.74% <97.74%> (ø) 33.00 <33.00> (?)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e832dac...9732efc. Read the comment docs.

@chingor13 chingor13 merged commit 115d82b into master Mar 31, 2020
14 of 15 checks passed
@chingor13 chingor13 deleted the v1 branch Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants