Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(samples): adds samples from documentation with correct region tags #392

Merged
merged 11 commits into from Jul 15, 2021

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Dec 17, 2020

Fixes #369

@pmakani pmakani requested review from steffnay and Dec 17, 2020
@google-cla
Copy link

@google-cla google-cla bot commented Dec 17, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@product-auto-label product-auto-label bot added the api: datacatalog label Dec 17, 2020
@google-cla google-cla bot added the cla: no label Dec 17, 2020
@snippet-bot
Copy link

@snippet-bot snippet-bot bot commented Dec 17, 2020

Here is the summary of changes.

You are about to add 5 region tags.
You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples label Dec 17, 2020
@pmakani
Copy link
Contributor Author

@pmakani pmakani commented Dec 17, 2020

@googlebot I consent.

@google-cla
Copy link

@google-cla google-cla bot commented Dec 17, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@pmakani
Copy link
Contributor Author

@pmakani pmakani commented Dec 17, 2020

@googlebot I consent

@google-cla
Copy link

@google-cla google-cla bot commented Dec 17, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@eaball35
Copy link
Contributor

@eaball35 eaball35 commented Dec 17, 2020

Screen Shot 2020-12-17 at 8 59 36 AM
Screen Shot 2020-12-17 at 8 59 57 AM

@eaball35 eaball35 added the kokoro:force-run label Jan 20, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jan 20, 2021
eaball35
eaball35 previously requested changes Jan 25, 2021
Copy link
Contributor

@eaball35 eaball35 left a comment

blocking checks

@eaball35
Copy link
Contributor

@eaball35 eaball35 commented Feb 1, 2021

Should we close this?

@eaball35 eaball35 closed this Feb 1, 2021
@meredithslota meredithslota reopened this Feb 26, 2021
@codecov
Copy link

@codecov codecov bot commented Feb 26, 2021

Codecov Report

Merging #392 (93b76b7) into master (443209c) will increase coverage by 1.02%.
The diff coverage is n/a.

Current head 93b76b7 differs from pull request most recent head f78d2a4. Consider uploading reports for the commit f78d2a4 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master     #392      +/-   ##
============================================
+ Coverage     81.20%   82.23%   +1.02%     
+ Complexity      744      595     -149     
============================================
  Files            36       24      -12     
  Lines          4917     3906    -1011     
  Branches         57       48       -9     
============================================
- Hits           3993     3212     -781     
+ Misses          823      610     -213     
+ Partials        101       84      -17     
Impacted Files Coverage Δ
...google/cloud/datacatalog/v1/DataCatalogClient.java 86.59% <0.00%> (-0.22%) ⬇️
...cloud/datacatalog/v1/stub/GrpcDataCatalogStub.java 97.79% <0.00%> (-0.08%) ⬇️
...e/cloud/datacatalog/v1beta1/DataCatalogClient.java 86.59% <0.00%> (ø)
...ud/datacatalog/v1beta1/PolicyTagManagerClient.java 79.05% <0.00%> (ø)
...acatalog/v1/stub/PolicyTagManagerStubSettings.java
...atalog/v1/PolicyTagManagerSerializationClient.java
...cloud/datacatalog/v1/PolicyTagManagerSettings.java
...tub/PolicyTagManagerSerializationStubSettings.java
...e/cloud/datacatalog/v1/PolicyTagManagerClient.java
...g/v1/stub/GrpcPolicyTagManagerCallableFactory.java
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e42312...f78d2a4. Read the comment docs.

@eaball35 eaball35 added the kokoro:force-run label Feb 26, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Feb 26, 2021
@meredithslota meredithslota added cla: yes and removed cla: no labels Feb 26, 2021
@meredithslota meredithslota requested review from stephaniewang526 and removed request for steffnay Feb 26, 2021
@stephaniewang526 stephaniewang526 added cla: yes and removed cla: no labels Jul 1, 2021
@google-cla
Copy link

@google-cla google-cla bot commented Jul 1, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Jul 1, 2021
@stephaniewang526 stephaniewang526 added cla: yes and removed cla: no labels Jul 1, 2021
@google-cla
Copy link

@google-cla google-cla bot commented Jul 1, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Jul 1, 2021
@stephaniewang526 stephaniewang526 added cla: yes kokoro:force-run and removed cla: no labels Jul 1, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jul 1, 2021
@google-cla
Copy link

@google-cla google-cla bot commented Jul 15, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Jul 15, 2021
@stephaniewang526 stephaniewang526 added cla: yes kokoro:force-run and removed cla: no labels Jul 15, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jul 15, 2021
@stephaniewang526 stephaniewang526 added the automerge label Jul 15, 2021
@stephaniewang526 stephaniewang526 requested a review from eaball35 Jul 15, 2021
@stephaniewang526 stephaniewang526 dismissed eaball35’s stale review Jul 15, 2021

Stephanie to review

@stephaniewang526 stephaniewang526 merged commit eff2228 into googleapis:master Jul 15, 2021
17 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Jul 15, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Aug 9, 2021
🤖 I have created a release \*beep\* \*boop\*
---
## [1.5.0](https://www.github.com/googleapis/java-datacatalog/compare/v1.4.2...v1.5.0) (2021-08-09)


### Features

* Added support for BigQuery connections entries feat: Added support for BigQuery routines entries feat: Added usage_signal field feat: Added labels field feat: Added ReplaceTaxonomy in Policy Tag Manager Serialization API feat: Added support for public tag templates feat: Added support for rich text tags docs: Documentation improvements ([#587](https://www.github.com/googleapis/java-datacatalog/issues/587)) ([2e7535b](https://www.github.com/googleapis/java-datacatalog/commit/2e7535b13cd6fb1ffa1caa8cb818f6d9be63a247))


### Documentation

* **samples:** adds samples from documentation with correct region tags ([#392](https://www.github.com/googleapis/java-datacatalog/issues/392)) ([eff2228](https://www.github.com/googleapis/java-datacatalog/commit/eff2228a09fc16d5b682740727f425d4290e1058))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datacatalog cla: yes samples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants