googleapis / java-dataproc Public
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: AutoscalingPolicyName now uses locations instead of regions #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ignatures - remove resource_reference not on a string field - adjust resource name pattern orders googleapis/googleapis@558b800 commit 558b800ed594acc02555cc560fbb39c0e42bc438 Author: Google APIs <noreply@google.com> Date: Fri Mar 27 16:35:33 2020 -0700 chore: turn on gapic v2 for Dataproc API. fix: - add missing method signatures - remove resource_reference not on a string field - adjust resource name pattern orders PiperOrigin-RevId: 303431167
Codecov Report
@@ Coverage Diff @@
## master #118 +/- ##
============================================
- Coverage 73.23% 72.12% -1.11%
Complexity 452 452
============================================
Files 48 48
Lines 3710 3774 +64
Branches 16 16
============================================
+ Hits 2717 2722 +5
- Misses 959 1014 +55
- Partials 34 38 +4
Continue to review full report at Codecov.
|
PTAL @chingor13 |
chingor13
approved these changes
Apr 1, 2020
gcf-merge-on-green bot
pushed a commit
that referenced
this issue
Apr 1, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [0.121.0](https://www.github.com/googleapis/java-dataproc/compare/v0.120.0...v0.121.0) (2020-04-01) ###⚠ BREAKING CHANGES * Please use AutoscalingPolicyName$Builder.setLocation(String) ### Bug Fixes * AutoscalingPolicyName now uses locations instead of regions ([#118](https://www.github.com/googleapis/java-dataproc/issues/118)) ([48110e6](https://www.github.com/googleapis/java-dataproc/commit/48110e6a7c6426172b81b126001a609650a4f3bd)) ### Dependencies * update dependency com.google.api:api-common to v1.9.0 ([#113](https://www.github.com/googleapis/java-dataproc/issues/113)) ([34b0ec6](https://www.github.com/googleapis/java-dataproc/commit/34b0ec60c21d76217d45b29410c1472ff8869ba0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
yoshi-automation
added a commit
that referenced
this issue
Apr 1, 2020
0d37f1a commit 0d37f1a Author: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Date: Wed Apr 1 22:18:09 2020 +0000 chore: release 0.121.0 (#120)🤖 I have created a release \*beep\* \*boop\* --- ## [0.121.0](https://www.github.com/googleapis/java-dataproc/compare/v0.120.0...v0.121.0) (2020-04-01) ###⚠ BREAKING CHANGES * Please use AutoscalingPolicyName$Builder.setLocation(String) ### Bug Fixes * AutoscalingPolicyName now uses locations instead of regions ([#118](https://www.github.com/googleapis/java-dataproc/issues/118)) ([48110e6](https://www.github.com/googleapis/java-dataproc/commit/48110e6a7c6426172b81b126001a609650a4f3bd)) ### Dependencies * update dependency com.google.api:api-common to v1.9.0 ([#113](https://www.github.com/googleapis/java-dataproc/issues/113)) ([34b0ec6](https://www.github.com/googleapis/java-dataproc/commit/34b0ec60c21d76217d45b29410c1472ff8869ba0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Regenerate with the protos and gapic configs in googleapis/googleapis@a45b0a2