Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: AutoscalingPolicyName now uses locations instead of regions #118

Merged
merged 3 commits into from Apr 1, 2020

Conversation

yihanzhen
Copy link
Contributor

@yihanzhen yihanzhen commented Mar 30, 2020

Regenerate with the protos and gapic configs in googleapis/googleapis@a45b0a2

yoshi-automation and others added 3 commits Mar 28, 2020
…ignatures - remove resource_reference not on a string field - adjust resource name pattern orders

googleapis/googleapis@558b800
commit 558b800ed594acc02555cc560fbb39c0e42bc438
Author: Google APIs <noreply@google.com>
Date:   Fri Mar 27 16:35:33 2020 -0700

    chore: turn on gapic v2 for Dataproc API.
    fix:
    - add missing method signatures
    - remove resource_reference not on a string field
    - adjust resource name pattern orders

    PiperOrigin-RevId: 303431167
@googlebot googlebot added the cla: yes label Mar 30, 2020
@codecov
Copy link

@codecov codecov bot commented Mar 30, 2020

Codecov Report

Merging #118 into master will decrease coverage by 1.1%.
The diff coverage is 64.37%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #118      +/-   ##
============================================
- Coverage     73.23%   72.12%   -1.11%     
  Complexity      452      452              
============================================
  Files            48       48              
  Lines          3710     3774      +64     
  Branches         16       16              
============================================
+ Hits           2717     2722       +5     
- Misses          959     1014      +55     
- Partials         34       38       +4
Impacted Files Coverage Δ Complexity Δ
...ud/dataproc/v1beta2/ClusterControllerSettings.java 14.89% <ø> (ø) 2 <0> (ø) ⬇️
...taproc/v1beta2/stub/GrpcClusterControllerStub.java 88.88% <ø> (ø) 13 <0> (ø) ⬇️
...d/dataproc/v1beta2/stub/ClusterControllerStub.java 7.69% <ø> (ø) 1 <0> (ø) ⬇️
...loud/dataproc/v1beta2/ClusterControllerClient.java 70.4% <ø> (ø) 21 <0> (ø) ⬇️
...dataproc/v1/stub/AutoscalingPolicyServiceStub.java 14.28% <0%> (ø) 1 <0> (ø) ⬇️
...ataproc/v1beta2/WorkflowTemplateServiceClient.java 50.78% <0%> (-6.24%) 25 <0> (ø)
...oud/dataproc/v1/WorkflowTemplateServiceClient.java 50.78% <0%> (-6.24%) 25 <0> (ø)
...taproc/v1beta2/AutoscalingPolicyServiceClient.java 55.68% <0%> (-6.35%) 18 <0> (ø)
.../dataproc/v1/AutoscalingPolicyServiceSettings.java 16.66% <0%> (ø) 2 <0> (ø) ⬇️
...eta2/stub/WorkflowTemplateServiceStubSettings.java 83.73% <100%> (ø) 18 <0> (ø) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc4f698...4e04707. Read the comment docs.

@yihanzhen
Copy link
Contributor Author

@yihanzhen yihanzhen commented Mar 30, 2020

PTAL @chingor13

@chingor13 chingor13 changed the title chore: regenerate with the latest protos fix!: AutoscalingPolicyName now uses locations instead of regions Apr 1, 2020
@chingor13 chingor13 merged commit 48110e6 into googleapis:master Apr 1, 2020
13 of 15 checks passed
gcf-merge-on-green bot pushed a commit that referenced this issue Apr 1, 2020
🤖 I have created a release \*beep\* \*boop\* 
---
## [0.121.0](https://www.github.com/googleapis/java-dataproc/compare/v0.120.0...v0.121.0) (2020-04-01)


###  BREAKING CHANGES

* Please use AutoscalingPolicyName$Builder.setLocation(String)

### Bug Fixes

* AutoscalingPolicyName now uses locations instead of regions ([#118](https://www.github.com/googleapis/java-dataproc/issues/118)) ([48110e6](https://www.github.com/googleapis/java-dataproc/commit/48110e6a7c6426172b81b126001a609650a4f3bd))


### Dependencies

* update dependency com.google.api:api-common to v1.9.0 ([#113](https://www.github.com/googleapis/java-dataproc/issues/113)) ([34b0ec6](https://www.github.com/googleapis/java-dataproc/commit/34b0ec60c21d76217d45b29410c1472ff8869ba0))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
yoshi-automation added a commit that referenced this issue Apr 1, 2020
0d37f1a
commit 0d37f1a
Author: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Date:   Wed Apr 1 22:18:09 2020 +0000

    chore: release 0.121.0 (#120)

    🤖 I have created a release \*beep\* \*boop\*
    ---
    ## [0.121.0](https://www.github.com/googleapis/java-dataproc/compare/v0.120.0...v0.121.0) (2020-04-01)

    ###  BREAKING CHANGES

    * Please use AutoscalingPolicyName$Builder.setLocation(String)

    ### Bug Fixes

    * AutoscalingPolicyName now uses locations instead of regions ([#118](https://www.github.com/googleapis/java-dataproc/issues/118)) ([48110e6](https://www.github.com/googleapis/java-dataproc/commit/48110e6a7c6426172b81b126001a609650a4f3bd))

    ### Dependencies

    * update dependency com.google.api:api-common to v1.9.0 ([#113](https://www.github.com/googleapis/java-dataproc/issues/113)) ([34b0ec6](https://www.github.com/googleapis/java-dataproc/commit/34b0ec60c21d76217d45b29410c1472ff8869ba0))
    ---

    This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants