feat: enable flag for report generation #1991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
lqiu96
reviewed
Oct 23, 2025
Comment on lines
63
to
66
| <plugin> | ||
| <groupId>org.codehaus.mojo</groupId> | ||
| <artifactId>clirr-maven-plugin</artifactId> | ||
| <configuration> | ||
| <skip>true</skip> <!-- TODO(gapic_upgrade): remove after first release --> | ||
| </configuration> | ||
| </plugin> |
Member
There was a problem hiding this comment.
I think CLIRR should be enabled by default via shared-configs. Can you double check if we can just delete this entire block?
lqiu96
previously approved these changes
Oct 23, 2025
Member
lqiu96
left a comment
lqiu96
left a comment
There was a problem hiding this comment.
Changes LGTM. Added a small note about CLIRR being default on (this was the last from when I last looked into it and may have changed).
lqiu96
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1557