Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LocalDatastoreHelper fails to start if used in an environment that cannot access the "gcd" GCS bucket #376

Closed
aristide-n opened this issue Apr 2, 2021 · 2 comments · Fixed by aristide-n/java-datastore#1, #492 or googleapis/java-core#513
Closed

LocalDatastoreHelper fails to start if used in an environment that cannot access the "gcd" GCS bucket #376

aristide-n opened this issue Apr 2, 2021 · 2 comments · Fixed by aristide-n/java-datastore#1, #492 or googleapis/java-core#513
Labels
api: datastore Issues related to the googleapis/java-datastore API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@aristide-n
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When attempting to use the Downloadable emulator, LocalDatastoreHelper downloads from a hardcoded URL to the file in the "gcd" GCS bucket:

java-datastore/google-cloud-datastore/src/main/java/com/google/cloud/datastore/testing/LocalDatastoreHelper.java

Line 75 in 1651b88

EMULATOR_URL = new URL("http://storage.googleapis.com/gcd/tools/" + FILENAME);

When used in an environment that cannot access the "gcd" GCS bucket, LocalDatastoreHelper fails to start (e.g. when running in a GCE VM protected by a VPC-SC perimeter).

Describe the solution you'd like
If I could provide the emulator file URL in an environment variable, I could copy the file from the "gcd" bucket into another bucket that is accessible from the restricted environment and use that URL.

Describe alternatives you've considered
N/A
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/java-datastore API. label Apr 2, 2021
aristide-n added a commit to aristide-n/java-datastore that referenced this issue Apr 2, 2021
@aristide-n
fix: LocalDatastoreHelper uses DATASTORE_EMULATOR_URL environment var…
dac49b2 
…iable value if provided

Fixes googleapis#376
@aristide-n aristide-n mentioned this issue Apr 2, 2021
Merged
@aristide-n aristide-n reopened this Apr 2, 2021
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 3, 2021
@dmahugh dmahugh added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Apr 9, 2021
@kolea2 kolea2 removed their assignment Apr 9, 2021
@kolea2 kolea2 removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 9, 2021
@aristide-n
Copy link
Contributor Author

I'm testing out a fix for this, I'll add a PR soon

aristide-n added a commit to aristide-n/java-datastore that referenced this issue May 9, 2021
@aristide-n
fix: LocalDatastoreHelper uses DATASTORE_EMULATOR_URL and ACCESS_TOKE…
86a9ad8 
…N environment variables values if provided

Fixes googleapis#376
aristide-n added a commit to aristide-n/java-datastore that referenced this issue May 9, 2021
@aristide-n
fix: LocalDatastoreHelper uses DATASTORE_EMULATOR_URL and ACCESS_TOKE…
386cd84 
…N environment variables values if provided

Fixes googleapis#376
aristide-n added a commit to aristide-n/java-datastore that referenced this issue May 9, 2021
@aristide-n
fix: LocalDatastoreHelper uses DATASTORE_EMULATOR_URL and ACCESS_TOKE…
e739998 
…N environment variables values if provided

Fixes googleapis#376
aristide-n added a commit to aristide-n/java-core that referenced this issue Aug 8, 2021
@aristide-n
feat: support downloading an emulator from an access controlled URL
904a5cd 
fixes googleapis/java-datastore#376
used in <googleapis/java-datastore#PR>
aristide-n added a commit to aristide-n/java-core that referenced this issue Aug 8, 2021
@aristide-n
feat: support downloading an emulator from an access controlled URL
09db6fa 
fixes googleapis/java-datastore#376
used in < googleapis/java-datastore#PR>
aristide-n added a commit to aristide-n/java-core that referenced this issue Aug 9, 2021
@aristide-n
feat: support downloading an emulator from an access controlled URL
1cb4002 
fixes googleapis/java-datastore#376
used in < googleapis/java-datastore#PR>
aristide-n added a commit to aristide-n/java-datastore that referenced this issue Aug 9, 2021
@aristide-n
feat: support overriding the emulator download URL in LocalDatastoreH…
440ab13 
…elper

fixes googleapis#376
This was referenced Aug 9, 2021
Merged
Merged
aristide-n added a commit to aristide-n/java-core that referenced this issue Aug 9, 2021
@aristide-n
feat: support downloading an emulator from an access controlled URL
fd7c0e0 
fixes googleapis/java-datastore#376
used in googleapis/java-datastore#492
lesv pushed a commit to googleapis/java-core that referenced this issue Aug 16, 2021
@aristide-n
feat: support downloading an emulator from an access controlled URL (#…
f42a707 
…513)

* feat: support downloading an emulator from an access controlled URL

fixes googleapis/java-datastore#376
used in googleapis/java-datastore#492

* fix format
@lesv lesv reopened this Aug 16, 2021
@lesv
Copy link
Contributor

lesv commented Aug 16, 2021

#492 is required before closing this.

gcf-merge-on-green bot pushed a commit that referenced this issue Aug 26, 2021
@aristide-n
feat: support overriding the emulator download URL in LocalDatastoreH…
76397bf 
…elper (#492)

Fixes #376
gcf-merge-on-green bot pushed a commit that referenced this issue Sep 1, 2021
@release-please
chore: release 2.1.0 (#519)
e4da914 
🤖 I have created a release \*beep\* \*boop\*
---
## [2.1.0](https://www.github.com/googleapis/java-datastore/compare/v2.0.3...v2.1.0) (2021-08-31)


### Features

* support overriding the emulator download URL in LocalDatastoreHelper ([#492](https://www.github.com/googleapis/java-datastore/issues/492)) ([76397bf](https://www.github.com/googleapis/java-datastore/commit/76397bf7ce27804101a1622e82f436cac0dcd605)), closes [#376](https://www.github.com/googleapis/java-datastore/issues/376)


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.2.0 ([#524](https://www.github.com/googleapis/java-datastore/issues/524)) ([81b9de5](https://www.github.com/googleapis/java-datastore/commit/81b9de5b8bc6e788618b2530a9f47ca97aa30d98))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
suztomo pushed a commit to googleapis/sdk-platform-java that referenced this issue Mar 21, 2023
@aristide-n
feat: support downloading an emulator from an access controlled URL (#…
0eeb60f 
…513)

* feat: support downloading an emulator from an access controlled URL

fixes googleapis/java-datastore#376
used in googleapis/java-datastore#492

* fix format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: datastore Issues related to the googleapis/java-datastore API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
5 participants
@dmahugh @lesv @aristide-n @yoshi-automation @kolea2