Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace all retry configs removed during GAPIC config migration #165

Merged
merged 1 commit into from May 1, 2020

Conversation

yoshi-automation
Copy link
Contributor

@yoshi-automation yoshi-automation commented May 1, 2020

This PR was generated using Autosynth. 馃寛

Synth log will be available here:
https://source.cloud.google.com/results/invocations/692159d3-355c-41ac-84f8-d15270d6214c/targets

PiperOrigin-RevId: 309415646

Source-Author: Google APIs <noreply@google.com>
Source-Date: Fri May 1 09:02:38 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: f78da0d54c78aa8f66d52a448db1f7ec0e0fd591
Source-Link: googleapis/googleapis@f78da0d
@googlebot googlebot added the cla: yes label May 1, 2020
@codecov
Copy link

@codecov codecov bot commented May 1, 2020

Codecov Report

Merging #165 into master will not change coverage.
The diff coverage is 83.68%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #165   +/-   ##
=========================================
  Coverage     71.41%   71.41%           
  Complexity      190      190           
=========================================
  Files             6        6           
  Lines          1847     1847           
  Branches          6        6           
=========================================
  Hits           1319     1319           
  Misses          489      489           
  Partials         39       39           
Impacted Files Coverage 螖 Complexity 螖
...java/com/google/cloud/dlp/v2/DlpServiceClient.java 47.36% <酶> (酶) 103.00 <0.00> (酶)
...va/com/google/cloud/dlp/v2/DlpServiceSettings.java 7.52% <0.00%> (酶) 2.00 <0.00> (酶)
...a/com/google/cloud/dlp/v2/stub/DlpServiceStub.java 2.56% <0.00%> (酶) 1.00 <0.00> (酶)
...ogle/cloud/dlp/v2/stub/DlpServiceStubSettings.java 82.95% <82.79%> (酶) 42.00 <8.00> (酶)
...m/google/cloud/dlp/v2/stub/GrpcDlpServiceStub.java 98.06% <99.37%> (酶) 39.00 <12.00> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 9da5fa1...8013618. Read the comment docs.

@noahdietz
Copy link

@noahdietz noahdietz commented May 1, 2020

I diff'd the DlpServiceStubSettings.java changes in this PR against that of the commit preceding the offending commit and there is virtually no difference (just a one line comment change). Thus this should restore the retry settings properly.

The remaining diffs I believe are just from reordering of the generated code (gapic config order vs. proto order) and binary compatibility passes.

@chingor13 chingor13 merged commit 02da00e into master May 1, 2020
15 checks passed
@chingor13 chingor13 deleted the autosynth-googleapis branch May 1, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants