Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flaky testInspectStringMultipleRulesPatientRule #264

Merged
merged 1 commit into from Sep 1, 2020

Conversation

athakor
Copy link
Contributor

@athakor athakor commented Sep 1, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #253

@athakor athakor requested a review from Sep 1, 2020
@google-cla google-cla bot added the cla: yes label Sep 1, 2020
@codecov
Copy link

@codecov codecov bot commented Sep 1, 2020

Codecov Report

Merging #264 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #264   +/-   ##
=========================================
  Coverage     73.56%   73.56%           
  Complexity      213      213           
=========================================
  Files             6        6           
  Lines          1899     1899           
  Branches         52       52           
=========================================
  Hits           1397     1397           
  Misses          465      465           
  Partials         37       37           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c45dc27...d186b71. Read the comment docs.

@athakor athakor merged commit f8dda41 into googleapis:master Sep 1, 2020
16 checks passed
gcf-merge-on-green bot pushed a commit that referenced this issue Oct 31, 2020
🤖 I have created a release \*beep\* \*boop\* 
---
## [2.2.0](https://www.github.com/googleapis/java-dlp/compare/v2.1.0...v2.2.0) (2020-10-31)


### Features

* retrieve job config for risk analysis jobs. docs: clarify timespan config for BigQuery and Datastore ([#302](https://www.github.com/googleapis/java-dlp/issues/302)) ([58d12e2](https://www.github.com/googleapis/java-dlp/commit/58d12e261665c5beee897b71498b8c2a980e81ba))


### Bug Fixes

* flaky testInspectStringMultipleRulesPatientRule ([#264](https://www.github.com/googleapis/java-dlp/issues/264)) ([f8dda41](https://www.github.com/googleapis/java-dlp/commit/f8dda413972df0e348440ffd76d453536731c2bd))


### Documentation

* correct the links for parent fields ([#274](https://www.github.com/googleapis/java-dlp/issues/274)) ([44e6c76](https://www.github.com/googleapis/java-dlp/commit/44e6c769f536b6333cc1535329c503e4051e0445))
* expand parent field format, and BigQuery sampling options. Also describing which transformations are allowed for ReidentifyContent API calls, and the custom alphabet allowed for format-preserving encryption (FPE). ([#266](https://www.github.com/googleapis/java-dlp/issues/266)) ([9a10739](https://www.github.com/googleapis/java-dlp/commit/9a10739284127974c669bd3580ebe29a8f8316a4))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.10.0 ([#287](https://www.github.com/googleapis/java-dlp/issues/287)) ([680692f](https://www.github.com/googleapis/java-dlp/commit/680692f82f84249467767e75dcfe00457a98351d))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.10.2 ([#298](https://www.github.com/googleapis/java-dlp/issues/298)) ([4bf3dc4](https://www.github.com/googleapis/java-dlp/commit/4bf3dc4b29c1d937eeaf72418e19ce9adbe631d5))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.12.1 ([#315](https://www.github.com/googleapis/java-dlp/issues/315)) ([b00c1a3](https://www.github.com/googleapis/java-dlp/commit/b00c1a312bfef30f831f2b1d3c9b063cb9dba8d5))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.13.0 ([#320](https://www.github.com/googleapis/java-dlp/issues/320)) ([a836cbd](https://www.github.com/googleapis/java-dlp/commit/a836cbd9057f363d9e5129c1be847ad35723209f))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.9.0 ([#263](https://www.github.com/googleapis/java-dlp/issues/263)) ([56feeb2](https://www.github.com/googleapis/java-dlp/commit/56feeb23faf5fafebeadf98a8a75ac4b64630336))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants