Skip to content
This repository was archived by the owner on Sep 16, 2023. It is now read-only.

Commit 6c7744a

Browse files
fix: Fixing PHP, Ruby and C# package names for the CloudDMS API (#4)
Committer: @jmpfar PiperOrigin-RevId: 373087373 Source-Link: googleapis/googleapis@6c96d19 Source-Link: https://github.com/googleapis/googleapis-gen/commit/92a9c9beab8f878d6f0a4cae9a0b9285c7d21a3e
1 parent 5a3ed07 commit 6c7744a

File tree

6 files changed

+29
-19
lines changed

6 files changed

+29
-19
lines changed

proto-google-cloud-dms-v1/src/main/java/com/google/cloud/clouddms/v1/ClouddmsProto.java

+6-4
Original file line numberDiff line numberDiff line change
@@ -313,10 +313,12 @@ public static com.google.protobuf.Descriptors.FileDescriptor getDescriptor() {
313313
+ "ionProfiles/*}\332A\004name\312A*\n\025google.protobu"
314314
+ "f.Empty\022\021OperationMetadata\032P\312A\034datamigra"
315315
+ "tion.googleapis.com\322A.https://www.google"
316-
+ "apis.com/auth/cloud-platformBq\n\034com.goog"
317-
+ "le.cloud.clouddms.v1B\rClouddmsProtoP\001Z@g"
318-
+ "oogle.golang.org/genproto/googleapis/clo"
319-
+ "ud/clouddms/v1;clouddmsb\006proto3"
316+
+ "apis.com/auth/cloud-platformB\305\001\n\034com.goo"
317+
+ "gle.cloud.clouddms.v1B\rClouddmsProtoP\001Z@"
318+
+ "google.golang.org/genproto/googleapis/cl"
319+
+ "oud/clouddms/v1;clouddms\252\002\030Google.Cloud."
320+
+ "CloudDms.V1\312\002\030Google\\Cloud\\CloudDms\\V1\352\002"
321+
+ "\033Google::Cloud::CloudDMS::V1b\006proto3"
320322
};
321323
descriptor =
322324
com.google.protobuf.Descriptors.FileDescriptor.internalBuildGeneratedFileFrom(

proto-google-cloud-dms-v1/src/main/java/com/google/cloud/clouddms/v1/ClouddmsResourcesProto.java

+7-5
Original file line numberDiff line numberDiff line change
@@ -274,11 +274,13 @@ public static com.google.protobuf.Descriptors.FileDescriptor getDescriptor() {
274274
+ "\016DatabaseEngine\022\037\n\033DATABASE_ENGINE_UNSPE"
275275
+ "CIFIED\020\000\022\t\n\005MYSQL\020\001\022\016\n\nPOSTGRESQL\020\002*L\n\020D"
276276
+ "atabaseProvider\022!\n\035DATABASE_PROVIDER_UNS"
277-
+ "PECIFIED\020\000\022\014\n\010CLOUDSQL\020\001\022\007\n\003RDS\020\002Bz\n\034com"
278-
+ ".google.cloud.clouddms.v1B\026ClouddmsResou"
279-
+ "rcesProtoP\001Z@google.golang.org/genproto/"
280-
+ "googleapis/cloud/clouddms/v1;clouddmsb\006p"
281-
+ "roto3"
277+
+ "PECIFIED\020\000\022\014\n\010CLOUDSQL\020\001\022\007\n\003RDS\020\002B\316\001\n\034co"
278+
+ "m.google.cloud.clouddms.v1B\026ClouddmsReso"
279+
+ "urcesProtoP\001Z@google.golang.org/genproto"
280+
+ "/googleapis/cloud/clouddms/v1;clouddms\252\002"
281+
+ "\030Google.Cloud.CloudDms.V1\312\002\030Google\\Cloud"
282+
+ "\\CloudDms\\V1\352\002\033Google::Cloud::CloudDMS::"
283+
+ "V1b\006proto3"
282284
};
283285
descriptor =
284286
com.google.protobuf.Descriptors.FileDescriptor.internalBuildGeneratedFileFrom(

proto-google-cloud-dms-v1/src/main/java/com/google/cloud/clouddms/v1/SqlIpConfig.java

+7-7
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ public com.google.protobuf.BoolValueOrBuilder getEnableIpv4OrBuilder() {
212212
* <pre>
213213
* The resource link for the VPC network from which the Cloud SQL instance is
214214
* accessible for private IP. For example,
215-
* `/projects/myProject/global/networks/default`. This setting can
215+
* `projects/myProject/global/networks/default`. This setting can
216216
* be updated, but it cannot be removed after it is set.
217217
* </pre>
218218
*
@@ -238,7 +238,7 @@ public java.lang.String getPrivateNetwork() {
238238
* <pre>
239239
* The resource link for the VPC network from which the Cloud SQL instance is
240240
* accessible for private IP. For example,
241-
* `/projects/myProject/global/networks/default`. This setting can
241+
* `projects/myProject/global/networks/default`. This setting can
242242
* be updated, but it cannot be removed after it is set.
243243
* </pre>
244244
*
@@ -1010,7 +1010,7 @@ public com.google.protobuf.BoolValueOrBuilder getEnableIpv4OrBuilder() {
10101010
* <pre>
10111011
* The resource link for the VPC network from which the Cloud SQL instance is
10121012
* accessible for private IP. For example,
1013-
* `/projects/myProject/global/networks/default`. This setting can
1013+
* `projects/myProject/global/networks/default`. This setting can
10141014
* be updated, but it cannot be removed after it is set.
10151015
* </pre>
10161016
*
@@ -1035,7 +1035,7 @@ public java.lang.String getPrivateNetwork() {
10351035
* <pre>
10361036
* The resource link for the VPC network from which the Cloud SQL instance is
10371037
* accessible for private IP. For example,
1038-
* `/projects/myProject/global/networks/default`. This setting can
1038+
* `projects/myProject/global/networks/default`. This setting can
10391039
* be updated, but it cannot be removed after it is set.
10401040
* </pre>
10411041
*
@@ -1060,7 +1060,7 @@ public com.google.protobuf.ByteString getPrivateNetworkBytes() {
10601060
* <pre>
10611061
* The resource link for the VPC network from which the Cloud SQL instance is
10621062
* accessible for private IP. For example,
1063-
* `/projects/myProject/global/networks/default`. This setting can
1063+
* `projects/myProject/global/networks/default`. This setting can
10641064
* be updated, but it cannot be removed after it is set.
10651065
* </pre>
10661066
*
@@ -1084,7 +1084,7 @@ public Builder setPrivateNetwork(java.lang.String value) {
10841084
* <pre>
10851085
* The resource link for the VPC network from which the Cloud SQL instance is
10861086
* accessible for private IP. For example,
1087-
* `/projects/myProject/global/networks/default`. This setting can
1087+
* `projects/myProject/global/networks/default`. This setting can
10881088
* be updated, but it cannot be removed after it is set.
10891089
* </pre>
10901090
*
@@ -1104,7 +1104,7 @@ public Builder clearPrivateNetwork() {
11041104
* <pre>
11051105
* The resource link for the VPC network from which the Cloud SQL instance is
11061106
* accessible for private IP. For example,
1107-
* `/projects/myProject/global/networks/default`. This setting can
1107+
* `projects/myProject/global/networks/default`. This setting can
11081108
* be updated, but it cannot be removed after it is set.
11091109
* </pre>
11101110
*

proto-google-cloud-dms-v1/src/main/java/com/google/cloud/clouddms/v1/SqlIpConfigOrBuilder.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ public interface SqlIpConfigOrBuilder
6464
* <pre>
6565
* The resource link for the VPC network from which the Cloud SQL instance is
6666
* accessible for private IP. For example,
67-
* `/projects/myProject/global/networks/default`. This setting can
67+
* `projects/myProject/global/networks/default`. This setting can
6868
* be updated, but it cannot be removed after it is set.
6969
* </pre>
7070
*
@@ -79,7 +79,7 @@ public interface SqlIpConfigOrBuilder
7979
* <pre>
8080
* The resource link for the VPC network from which the Cloud SQL instance is
8181
* accessible for private IP. For example,
82-
* `/projects/myProject/global/networks/default`. This setting can
82+
* `projects/myProject/global/networks/default`. This setting can
8383
* be updated, but it cannot be removed after it is set.
8484
* </pre>
8585
*

proto-google-cloud-dms-v1/src/main/proto/google/cloud/clouddms/v1/clouddms.proto

+3
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,13 @@ import "google/longrunning/operations.proto";
2525
import "google/protobuf/field_mask.proto";
2626
import "google/protobuf/timestamp.proto";
2727

28+
option csharp_namespace = "Google.Cloud.CloudDms.V1";
2829
option go_package = "google.golang.org/genproto/googleapis/cloud/clouddms/v1;clouddms";
2930
option java_multiple_files = true;
3031
option java_outer_classname = "ClouddmsProto";
3132
option java_package = "com.google.cloud.clouddms.v1";
33+
option php_namespace = "Google\\Cloud\\CloudDms\\V1";
34+
option ruby_package = "Google::Cloud::CloudDMS::V1";
3235

3336
// Database Migration service
3437
service DataMigrationService {

proto-google-cloud-dms-v1/src/main/proto/google/cloud/clouddms/v1/clouddms_resources.proto

+4-1
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,13 @@ import "google/protobuf/wrappers.proto";
2424
import "google/rpc/status.proto";
2525
import "google/api/annotations.proto";
2626

27+
option csharp_namespace = "Google.Cloud.CloudDms.V1";
2728
option go_package = "google.golang.org/genproto/googleapis/cloud/clouddms/v1;clouddms";
2829
option java_multiple_files = true;
2930
option java_outer_classname = "ClouddmsResourcesProto";
3031
option java_package = "com.google.cloud.clouddms.v1";
32+
option php_namespace = "Google\\Cloud\\CloudDms\\V1";
33+
option ruby_package = "Google::Cloud::CloudDMS::V1";
3134

3235
// SSL configuration information.
3336
message SslConfig {
@@ -173,7 +176,7 @@ message SqlIpConfig {
173176

174177
// The resource link for the VPC network from which the Cloud SQL instance is
175178
// accessible for private IP. For example,
176-
// `/projects/myProject/global/networks/default`. This setting can
179+
// `projects/myProject/global/networks/default`. This setting can
177180
// be updated, but it cannot be removed after it is set.
178181
string private_network = 2;
179182

0 commit comments

Comments
 (0)