Skip to content
This repository has been archived by the owner on Sep 16, 2023. It is now read-only.

feat: add supports of labels while creating managed zone #289

Merged
merged 5 commits into from
Dec 28, 2020

Conversation

athakor
Copy link
Contributor

@athakor athakor commented Dec 24, 2020

Fixes #288

@athakor athakor requested a review from a team as a code owner December 24, 2020 12:24
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 24, 2020
@product-auto-label product-auto-label bot added the api: dns Issues related to the googleapis/java-dns API. label Dec 24, 2020
@codecov
Copy link

codecov bot commented Dec 24, 2020

Codecov Report

Merging #289 (311c099) into master (b3bdbd1) will decrease coverage by 0.07%.
The diff coverage is 73.68%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #289      +/-   ##
============================================
- Coverage     77.34%   77.26%   -0.08%     
- Complexity      175      178       +3     
============================================
  Files            15       15              
  Lines          1174     1192      +18     
  Branches        101      105       +4     
============================================
+ Hits            908      921      +13     
- Misses          215      218       +3     
- Partials         51       53       +2     
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/google/cloud/dns/Zone.java 77.55% <0.00%> (-3.31%) 15.00 <0.00> (ø)
src/main/java/com/google/cloud/dns/ZoneInfo.java 81.77% <80.00%> (-0.13%) 32.00 <1.00> (+3.00) ⬇️
src/main/java/com/google/cloud/dns/Dns.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3bdbd1...311c099. Read the comment docs.

@chingor13 chingor13 changed the title feat: add supports of labels while creating manazed zone feat: add supports of labels while creating managed zone Dec 28, 2020
@@ -378,6 +382,11 @@ private static void validateValue(String value, Set<String> validValues) {
public Builder setDnsSecConfig(DnsSecConfig dnsSecConfig) {
return this;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@chingor13 chingor13 merged commit 47b687f into googleapis:master Dec 28, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 22, 2021
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.1.0](https://www.github.com/googleapis/java-dns/compare/v1.0.8...v1.1.0) (2021-02-22)


### Features

* add supports of labels while creating managed zone ([#289](https://www.github.com/googleapis/java-dns/issues/289)) ([47b687f](https://www.github.com/googleapis/java-dns/commit/47b687f2aeadc25f24c0c9401be8062b87527580))
* expose DNSSEC options of ManagedZones ([#276](https://www.github.com/googleapis/java-dns/issues/276)) ([b3bdbd1](https://www.github.com/googleapis/java-dns/commit/b3bdbd1f9e1e593264908dcc913866c5876e1197))


### Bug Fixes

* don't log downloads ([#318](https://www.github.com/googleapis/java-dns/issues/318)) ([0b7cb06](https://www.github.com/googleapis/java-dns/commit/0b7cb06e30a8cd9e413375961701952acdb87e5e))
* update repo name ([#312](https://www.github.com/googleapis/java-dns/issues/312)) ([83cbd61](https://www.github.com/googleapis/java-dns/commit/83cbd610763b5010c9748094cbb8e3dbaceec11c))


### Dependencies

* update dependency com.google.apis:google-api-services-dns to v1-rev20210204-1.31.0 ([#315](https://www.github.com/googleapis/java-dns/issues/315)) ([29f0414](https://www.github.com/googleapis/java-dns/commit/29f0414b91b8922c87dbfe47ed7ea9ca3f8e0c90))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.18.0 ([#298](https://www.github.com/googleapis/java-dns/issues/298)) ([7da3244](https://www.github.com/googleapis/java-dns/commit/7da324461b3848acc66af7efbb827422a456ebdd))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.19.0 ([#319](https://www.github.com/googleapis/java-dns/issues/319)) ([e2da544](https://www.github.com/googleapis/java-dns/commit/e2da544fdd62017f21fc78e93dcfa296e83829fa))
* update dependency com.google.errorprone:error_prone_annotations to v2.5.1 ([#299](https://www.github.com/googleapis/java-dns/issues/299)) ([4919dcc](https://www.github.com/googleapis/java-dns/commit/4919dcc394a85b75d504b50167417d76c4a0a80a))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: dns Issues related to the googleapis/java-dns API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
3 participants