Skip to content
This repository has been archived by the owner on Sep 16, 2023. It is now read-only.

fix: make tests skippable with an environment variable #357

Merged
merged 3 commits into from
Apr 29, 2021

Conversation

carolynsun-google
Copy link
Contributor

Public zone requests to Cloud DNS are blocked when enforcing VPCSC. Make tests that involve public zone requests skippable.

Public zone requests to Cloud DNS are blocked when enforcing VCPS.
@carolynsun-google carolynsun-google requested a review from a team as a code owner March 24, 2021 19:01
@product-auto-label product-auto-label bot added the api: dns Issues related to the googleapis/java-dns API. label Mar 24, 2021
@google-cla
Copy link

google-cla bot commented Mar 24, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Mar 24, 2021
@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #357 (f044856) into master (d748c6f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #357   +/-   ##
=========================================
  Coverage     77.26%   77.26%           
  Complexity      178      178           
=========================================
  Files            15       15           
  Lines          1192     1192           
  Branches        105      105           
=========================================
  Hits            921      921           
  Misses          218      218           
  Partials         53       53           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d748c6f...f044856. Read the comment docs.

Make tests that involve public zone requests skippable since public zone requests to Cloud DNS are blocked when enforcing VPCSC.
@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Apr 7, 2021
@carolynsun-google carolynsun-google changed the title Make tests skippable with an environment variable. fix: make tests skippable with an environment variable Apr 7, 2021
@stephaniewang526 stephaniewang526 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Apr 29, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 29, 2021
@stephaniewang526 stephaniewang526 merged commit bec7b9f into googleapis:master Apr 29, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 29, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request May 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: dns Issues related to the googleapis/java-dns API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
3 participants