fix: add cause to transaction errors on transaction commit#108
fix: add cause to transaction errors on transaction commit#108BenWhitehead merged 2 commits intogoogleapis:masterfrom rockwotj:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #108 +/- ##
============================================
- Coverage 71.97% 71.56% -0.41%
+ Complexity 997 968 -29
============================================
Files 62 62
Lines 5323 5202 -121
Branches 599 579 -20
============================================
- Hits 3831 3723 -108
+ Misses 1304 1299 -5
+ Partials 188 180 -8 Continue to review full report at Codecov.
|
|
@rockwotj Can you run |
BenWhitehead
left a comment
There was a problem hiding this comment.
Change looks good, just need to run the formatter.
|
FYI: We will shortly be addressing the transaction retry behavior across all of our SDKs. |
|
@rockwotj Can you update the PR title to follow conventionalcommits.org? It this case it would be: "fix: ddd cause to transaction errors on transaction commit" |
|
Thanks for the improvement @rockwotj! |
Right now if a transaction fails due to a precondition failure (which are retried, which is another bug) for example trying to update a document that doesn't exist you get a bad error message of "too many retries". Ideally retry is smarter, but this is a easy change that propagates the underlying error up to the ApiFuture result.
/cc @schmidt-sebastian @BenWhitehead