fix: add support for updating an individual field with pojo in all update method#136
Merged
BenWhitehead merged 3 commits intogoogleapis:masterfrom Mar 27, 2020
Merged
Conversation
googlebot
added
the
cla: yes
athakor
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
suraj-qlogic
changed the title
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
============================================
+ Coverage 71.56% 71.63% +0.06%
- Complexity 968 969 +1
============================================
Files 62 62
Lines 5202 5224 +22
Branches 579 579
============================================
+ Hits 3723 3742 +19
- Misses 1299 1302 +3
Partials 180 180
Continue to review full report at Codecov.
|
BenWhitehead
suggested changes
Mar 19, 2020
Contributor
BenWhitehead
left a comment
BenWhitehead
left a comment
There was a problem hiding this comment.
Thanks @suraj-qlogic Can you add some tests to ensure that this fix is covering what is asked for in the original bug, and to ensure it doesn't accidentally get broken in the future.
pmakani
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
| } | ||
| } | ||
|
|
||
| public static class FooModel { |
Contributor
There was a problem hiding this comment.
Do you mind re-using the SingleField example Pojo that exists in this class?
Contributor
|
@BenWhitehead This looks good to me, but we should try to replace the FooModel usage with SingleField before merging. |
pmakani
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
schmidt-sebastian
approved these changes
Mar 27, 2020
Contributor
schmidt-sebastian
left a comment
schmidt-sebastian
left a comment
There was a problem hiding this comment.
Thanks, this LGTM.
schmidt-sebastian
approved these changes
Mar 27, 2020
BenWhitehead
approved these changes
Mar 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #126