fix: add missing @InternalExtensionOnly annotation to com.google.cloud.firestore.Firestore#141
Merged
BenWhitehead merged 1 commit intogoogleapis:masterfrom Mar 20, 2020
BenWhitehead:internal-annotation
Merged
fix: add missing @InternalExtensionOnly annotation to com.google.cloud.firestore.Firestore#141BenWhitehead merged 1 commit intogoogleapis:masterfrom BenWhitehead:internal-annotation
BenWhitehead merged 1 commit intogoogleapis:masterfrom
BenWhitehead:internal-annotation
Conversation
…d.firestore.Firestore "Client" interfaces make guarantees around compatibility for users direct usage, however no guarantee is made for anyone implementing the "client" interface themselves. This change adds the annotation intended to convey this guarantee at the code level and in javadocs that should have been here all along.
googlebot
added
the
cla: yes
Contributor
Author
|
/cc @vam-google |
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
=========================================
Coverage 71.56% 71.56%
Complexity 968 968
=========================================
Files 62 62
Lines 5202 5202
Branches 579 579
=========================================
Hits 3723 3723
Misses 1299 1299
Partials 180 180 Continue to review full report at Codecov.
|
chingor13
approved these changes
Mar 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Client" interfaces make guarantees around compatibility for users
direct usage, however no guarantee is made for anyone implementing
the "client" interface themselves. This change adds the annotation
intended to convey this guarantee at the code level and in javadocs
that should have been here all along.