fix: don't throw NPE in DocumentSnapshot.getDate() when value is missing#513
Merged
schmidt-sebastian merged 2 commits intomasterfrom Jan 26, 2021
Merged
fix: don't throw NPE in DocumentSnapshot.getDate() when value is missing#513schmidt-sebastian merged 2 commits intomasterfrom
schmidt-sebastian merged 2 commits intomasterfrom
Conversation
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: firestore
Codecov Report
@@ Coverage Diff @@
## master #513 +/- ##
============================================
- Coverage 74.09% 74.08% -0.02%
+ Complexity 1117 1108 -9
============================================
Files 66 66
Lines 5883 5884 +1
Branches 723 726 +3
============================================
Hits 4359 4359
Misses 1296 1296
- Partials 228 229 +1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #491