Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: google-cloud-kms-bom should not include itself #22

Merged
merged 1 commit into from Nov 26, 2019

Conversation

chingor13
Copy link
Collaborator

@chingor13 chingor13 commented Nov 26, 2019

Fixes #21

@googlebot googlebot added the cla: yes label Nov 26, 2019
@chingor13 chingor13 requested a review from Nov 26, 2019
@codecov
Copy link

@codecov codecov bot commented Nov 26, 2019

Codecov Report

Merging #22 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #22   +/-   ##
=========================================
  Coverage     77.56%   77.56%           
  Complexity      177      177           
=========================================
  Files             6        6           
  Lines          1435     1435           
  Branches         24       24           
=========================================
  Hits           1113     1113           
  Misses          290      290           
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07f7385...6517899. Read the comment docs.

elharo
elharo approved these changes Nov 26, 2019
@chingor13 chingor13 merged commit fa4c58a into master Nov 26, 2019
12 checks passed
@chingor13 chingor13 deleted the chingor13-patch-1 branch Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants