Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not retry on 13 INTERNAL #396

Merged
merged 6 commits into from Feb 16, 2021
Merged

Conversation

yoshi-automation
Copy link
Contributor

@yoshi-automation yoshi-automation commented Feb 11, 2021

This PR was generated using Autosynth. 馃寛

Synth log will be available here:
https://source.cloud.google.com/results/invocations/a7d32ac5-d75c-4316-9418-8435525bdb8d/targets

  • To automatically regenerate this PR, check this box.

PiperOrigin-RevId: 357022763
Source-Link: googleapis/googleapis@3f914b8
PiperOrigin-RevId: 351867503
Source-Link: googleapis/googleapis@f1b2cc9
PiperOrigin-RevId: 350949863
Source-Link: googleapis/googleapis@91e206b
PiperOrigin-RevId: 350067652
Source-Link: googleapis/googleapis@ad3bb00
PiperOrigin-RevId: 347036369
Source-Link: googleapis/googleapis@6d65640
PiperOrigin-RevId: 346440719
Source-Link: googleapis/googleapis@85a5954

chore: migrate kms to the Java microgenerator
chore: update gapic-generator-java to 0.0.11
chore: update gapic-generator-java to 0.0.16
chore: update gapic-generator-java to 0.0.18
chore: un-migrate kms from the Java microgenerator to the monolith

Committer: @miraleung
PiperOrigin-RevId: 346440719

Source-Author: Google APIs <noreply@google.com>
Source-Date: Tue Dec 8 16:57:38 2020 -0800
Source-Repo: googleapis/googleapis
Source-Sha: 85a5954183479a9a7c2641c013cd728b6fa9b7cd
Source-Link: googleapis/googleapis@85a5954
Committer: @miraleung
PiperOrigin-RevId: 347036369

Source-Author: Google APIs <noreply@google.com>
Source-Date: Fri Dec 11 11:13:47 2020 -0800
Source-Repo: googleapis/googleapis
Source-Sha: 6d65640b1fcbdf26ea76cb720de0ac138cae9bed
Source-Link: googleapis/googleapis@6d65640
Committer: @miraleung
PiperOrigin-RevId: 350067652

Source-Author: Google APIs <noreply@google.com>
Source-Date: Mon Jan 4 19:45:21 2021 -0800
Source-Repo: googleapis/googleapis
Source-Sha: ad3bb00ed7750cd0625b3a36e0e2eff29f778e4a
Source-Link: googleapis/googleapis@ad3bb00
Committer: @miraleung
PiperOrigin-RevId: 350949863

Source-Author: Google APIs <noreply@google.com>
Source-Date: Sat Jan 9 14:01:49 2021 -0800
Source-Repo: googleapis/googleapis
Source-Sha: 91e206bcfeaf8948ea03fe3cb1b7616108496cd3
Source-Link: googleapis/googleapis@91e206b
Committer: @miraleung
PiperOrigin-RevId: 351867503

Source-Author: Google APIs <noreply@google.com>
Source-Date: Thu Jan 14 13:38:11 2021 -0800
Source-Repo: googleapis/googleapis
Source-Sha: f1b2cc9c37f453c3b15e8945af32812f71634022
Source-Link: googleapis/googleapis@f1b2cc9
Fixes googleapis/nodejs-kms#375. The malformed request triggers `13 INTERNAL` from gRPC and we should not silently retry on this code.
Committer: @alexander-fenster

PiperOrigin-RevId: 357022763

Source-Author: Google APIs <noreply@google.com>
Source-Date: Thu Feb 11 11:39:31 2021 -0800
Source-Repo: googleapis/googleapis
Source-Sha: 3f914b89ae1ef459955f470f9ccb498314ad28d5
Source-Link: googleapis/googleapis@3f914b8
@yoshi-automation yoshi-automation requested a review from as a code owner Feb 11, 2021
@product-auto-label product-auto-label bot added the api: cloudkms label Feb 11, 2021
@google-cla google-cla bot added the cla: yes label Feb 11, 2021
@codecov
Copy link

@codecov codecov bot commented Feb 11, 2021

Codecov Report

Merging #396 (8c335c6) into master (2d14599) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #396   +/-   ##
=========================================
  Coverage     76.81%   76.81%           
  Complexity      174      174           
=========================================
  Files             6        6           
  Lines          1449     1449           
  Branches         25       25           
=========================================
  Hits           1113     1113           
  Misses          307      307           
  Partials         29       29           
Impacted Files Coverage 螖 Complexity 螖
.../kms/v1/stub/KeyManagementServiceStubSettings.java 83.50% <酶> (酶) 36.00 <0.00> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 2d14599...8c335c6. Read the comment docs.

@Neenu1995 Neenu1995 changed the title [CHANGE ME] Re-generated to pick up changes from googleapis. fix: do not retry on 13 INTERNAL Feb 16, 2021
@Neenu1995 Neenu1995 added the automerge label Feb 16, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit ea2f95a into master Feb 16, 2021
18 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the autosynth-googleapis branch Feb 16, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Feb 16, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudkms cla: yes context: full
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants