This repository was archived by the owner on Feb 6, 2026. It is now read-only.
fix: make TransportChannel autocloseable#212
Merged
chingor13 merged 2 commits intogoogleapis:masterfrom Sep 8, 2020
Merged
Conversation
google-cla
bot
added
the
cla: yes
simonz130
previously requested changes
Aug 18, 2020
| .setBackgroundResources( | ||
| Collections.<BackgroundResource>singletonList(transportChannel)) | ||
| .build(); | ||
| } |
There was a problem hiding this comment.
where is the catch block for this try?
Codecov Report
@@ Coverage Diff @@
## master #212 +/- ##
============================================
- Coverage 75.17% 75.14% -0.04%
Complexity 593 593
============================================
Files 42 42
Lines 3646 3649 +3
Branches 251 251
============================================
+ Hits 2741 2742 +1
- Misses 757 759 +2
Partials 148 148
Continue to review full report at Codecov.
|
product-auto-label
bot
added
the
api: logging
Contributor
Author
|
@simonz130 ,PTAL |
chingor13
approved these changes
Sep 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #211