fix: Mark a couple networkconnectivity API fields as required, to match implemented behavior #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcf-owl-bot[bot]](https://avatars.githubusercontent.com/in/99011?s=60&v=4){kind=small}
…tch implemented behavior PiperOrigin-RevId: 408969147 Source-Link: googleapis/googleapis@cc003a4 Source-Link: https://github.com/googleapis/googleapis-gen/commit/72d5b22e2124c7a5f6cd31864f7f8c93a5df3592 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzJkNWIyMmUyMTI0YzdhNWY2Y2QzMTg2NGY3ZjhjOTNhNWRmMzU5MiJ9
google-cla
bot
added
the
cla: yes
trusted-contributions-gcf
bot
added
kokoro:force-run
product-auto-label
bot
added
the
api: networkconnectivity
yoshi-kokoro
removed
the
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
trusted-contributions-gcf
bot
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
Neenu1995
changed the title
|
Not a breaking change for java because we don't flatten the request params into the method signature. |
Neenu1995
approved these changes
Nov 11, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this issue
Jan 7, 2022
🤖 I have created a release \*beep\* \*boop\* --- ## [0.5.0](https://www.github.com/googleapis/java-networkconnectivity/compare/v0.4.0...v0.5.0) (2022-01-07) ### Features * Remove use of deprecated gradle command in java README ([#1196](https://www.github.com/googleapis/java-networkconnectivity/issues/1196)) ([#140](https://www.github.com/googleapis/java-networkconnectivity/issues/140)) ([1815962](https://www.github.com/googleapis/java-networkconnectivity/commit/181596270ab199a77b78cc7eda7100e24102526f)) ### Bug Fixes * **java:** add -ntp flag to native image testing command ([#1299](https://www.github.com/googleapis/java-networkconnectivity/issues/1299)) ([#182](https://www.github.com/googleapis/java-networkconnectivity/issues/182)) ([978dc4c](https://www.github.com/googleapis/java-networkconnectivity/commit/978dc4cf832ed987a3baa895909f7d47d195cfbb)) * **java:** java 17 dependency arguments ([#1266](https://www.github.com/googleapis/java-networkconnectivity/issues/1266)) ([#167](https://www.github.com/googleapis/java-networkconnectivity/issues/167)) ([a00e58d](https://www.github.com/googleapis/java-networkconnectivity/commit/a00e58d93bf12431d04f3f938a910faab9ac1711)) * Mark a couple networkconnectivity API fields as required, to match implemented behavior ([#174](https://www.github.com/googleapis/java-networkconnectivity/issues/174)) ([507173f](https://www.github.com/googleapis/java-networkconnectivity/commit/507173fd2d1b771a8db26201649dbf98786738f8)) * Remove ActivateSpoke and DeactivateSpoke methods ([#136](https://www.github.com/googleapis/java-networkconnectivity/issues/136)) ([5beedfa](https://www.github.com/googleapis/java-networkconnectivity/commit/5beedfa50c4ce32b0a25ad4fefa14ff254ecae19)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.0.1 ([#130](https://www.github.com/googleapis/java-networkconnectivity/issues/130)) ([6a4ad85](https://www.github.com/googleapis/java-networkconnectivity/commit/6a4ad85591d7751f075507be6979c3fcb9c001d3)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.1.0 ([#135](https://www.github.com/googleapis/java-networkconnectivity/issues/135)) ([0a6d812](https://www.github.com/googleapis/java-networkconnectivity/commit/0a6d812e352b9e2acf2a5d31ab3e2d2fd144a360)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.2.0 ([#142](https://www.github.com/googleapis/java-networkconnectivity/issues/142)) ([6e79651](https://www.github.com/googleapis/java-networkconnectivity/commit/6e79651d59b502e25fa7b04103ac26f4904655e0)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.2.1 ([#150](https://www.github.com/googleapis/java-networkconnectivity/issues/150)) ([fba50a8](https://www.github.com/googleapis/java-networkconnectivity/commit/fba50a820442feb8dec1c50409a8b4803bc52a22)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.3.0 ([#154](https://www.github.com/googleapis/java-networkconnectivity/issues/154)) ([1a843b1](https://www.github.com/googleapis/java-networkconnectivity/commit/1a843b16dbdfcfd3fcc7060f1d8871f74ba50dee)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.4.0 ([#164](https://www.github.com/googleapis/java-networkconnectivity/issues/164)) ([74e8a37](https://www.github.com/googleapis/java-networkconnectivity/commit/74e8a377cb0da038414ce0352067b9a328a1b860)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.5.0 ([#176](https://www.github.com/googleapis/java-networkconnectivity/issues/176)) ([680fc3d](https://www.github.com/googleapis/java-networkconnectivity/commit/680fc3d426b48689f665f179deddb2bd0cf6a0e7)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.5.1 ([#181](https://www.github.com/googleapis/java-networkconnectivity/issues/181)) ([c596af4](https://www.github.com/googleapis/java-networkconnectivity/commit/c596af4ff73046156570fccd080d7128e8af610d)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.6.0 ([#186](https://www.github.com/googleapis/java-networkconnectivity/issues/186)) ([eb46c69](https://www.github.com/googleapis/java-networkconnectivity/commit/eb46c696d28db34bed009a329b6ad5615e2978d4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
PiperOrigin-RevId: 408969147
Source-Link: googleapis/googleapis@cc003a4
Source-Link: https://github.com/googleapis/googleapis-gen/commit/72d5b22e2124c7a5f6cd31864f7f8c93a5df3592
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzJkNWIyMmUyMTI0YzdhNWY2Y2QzMTg2NGY3ZjhjOTNhNWRmMzU5MiJ9