Skip to content
Permalink
Browse files
fix: changing integration test push endpoint to be valid https (#170)
* Modifying Publish example in README to match other examples given, and
fix issue #6784

* fix: Modifying Publish example in README to match other examples, and
fix Issue #11

* feat: Adding support for DLQs

Adding delivery attempt count to PubsubMessages as a message attribute,
and creating helper function to allow users to get the count without
knowing implementation details.

* Fix formatting

* fix: making changes requested in pull request

* fix: creating fix to not populate delivery attempt attribute when dead
lettering is not enabled

* Adding unit test for case in which a received message has no delivery attempt

* Making MessageWaiter class more generic to also be used for outstanding
ack operations

* Waiting for acks to complete before shutting down a streaming subscriber
connection

* Fixing formatting error

* fix: making sure all publishes complete before shutting down the
publisher

* adding default max outstanding request bytes

* fix: make push endpoint valid https
  • Loading branch information
hannahrogers-google committed Apr 29, 2020
1 parent 6346042 commit 71f15a4a90475c8e82c6cc6393d4232228273656
Showing with 1 addition and 1 deletion.
  1. +1 −1 google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/it/ITPubSubTest.java
@@ -126,7 +126,7 @@ public void testVPCPushSubscriber() {
subscriptionAdminClient.createSubscription(
subscriptionName,
topicName,
PushConfig.newBuilder().setPushEndpoint("random_point").build(),
PushConfig.newBuilder().setPushEndpoint("https://random_point").build(),
10);
subscriptionAdminClient.deleteSubscription(subscriptionName);
Assert.fail("No exception raised");

0 comments on commit 71f15a4

Please sign in to comment.