feat: add TopicName #113
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
@@ Coverage Diff @@ ## master #113 +/- ## ========================================== - Coverage 79.36% 78.37% -1% + Complexity 305 302 -3 ========================================== Files 21 21 Lines 2603 2719 +116 Branches 115 134 +19 ========================================== + Hits 2066 2131 +65 - Misses 467 513 +46 - Partials 70 75 +5
Also what is the samples test for?
vam-google added a commit to vam-google/java-pubsub that referenced this issue
Mar 30, 2020
This PR migrates only synth.py but does not commit the regenerated files. The generation was tested and it works, the updated files are not commited due to breaking changes not related to bazel migration. This PR should be pushed after the an already open PR with the braking changes: googleapis#113
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.