feat: add interfaces for cloud pubsub publishers and subscribers #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dpcollins-google
requested review from
kamalaboulhosn and
hannahrogers-google
and removed request for
kamalaboulhosn
|
|
||
| import com.google.api.core.ApiService; | ||
|
|
||
| // The core interface for a Cloud Pub/Sub subscriber, consisting only of ApiService methods. |
There was a problem hiding this comment.
Can we change this to be a java doc comment
/*
*/
And add a link to subscriber documentation, like you did with the PublisherInterface
|
You can also resolve the code format failure by running 'mvn clean verify' |
hannahrogers-google
changed the title
|
|
||
| import com.google.api.core.ApiService; | ||
|
|
||
| /** The core interface for a Cloud Pub/Sub |
There was a problem hiding this comment.
'The core interface...' should be on a new line
Running 'mvn clean verify' should resolve this
hannahrogers-google
approved these changes
Apr 9, 2020
dpcollins-google
force-pushed
the
master
branch
from
3376faa
to
7e52c62
Compare
dpcollins-google
force-pushed
the
master
branch
from
7e52c62
to
c4039ce
Compare
hannahrogers-google
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
=========================================
Coverage 78.37% 78.37%
Complexity 302 302
=========================================
Files 21 21
Lines 2719 2719
Branches 134 134
=========================================
Hits 2131 2131
Misses 513 513
Partials 75 75
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.