Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add interfaces for cloud pubsub publishers and subscribers #134

Merged
merged 1 commit into from Apr 10, 2020

Conversation

dpcollins-google
Copy link
Contributor

@dpcollins-google dpcollins-google commented Apr 9, 2020

No description provided.

@googlebot googlebot added the cla: yes label Apr 9, 2020
@dpcollins-google dpcollins-google requested review from kamalaboulhosn and hannahrogers-google and removed request for kamalaboulhosn Apr 9, 2020

import com.google.api.core.ApiService;

// The core interface for a Cloud Pub/Sub subscriber, consisting only of ApiService methods.
Copy link
Contributor

@hannahrogers-google hannahrogers-google Apr 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this to be a java doc comment
/*
*/

And add a link to subscriber documentation, like you did with the PublisherInterface

Copy link
Contributor Author

@dpcollins-google dpcollins-google Apr 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@hannahrogers-google
Copy link
Contributor

@hannahrogers-google hannahrogers-google commented Apr 9, 2020

You can also resolve the code format failure by running 'mvn clean verify'

@hannahrogers-google hannahrogers-google changed the title Add interfaces for Cloud Pub/Sub Publishers and Subscribers. feat: add interfaces for cloud pubsub publishers and subscribers Apr 9, 2020

import com.google.api.core.ApiService;

/** The core interface for a Cloud Pub/Sub
Copy link
Contributor

@hannahrogers-google hannahrogers-google Apr 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'The core interface...' should be on a new line

Running 'mvn clean verify' should resolve this

Copy link
Contributor Author

@dpcollins-google dpcollins-google Apr 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@hannahrogers-google hannahrogers-google added the kokoro:force-run label Apr 10, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Apr 10, 2020
@codecov
Copy link

@codecov codecov bot commented Apr 10, 2020

Codecov Report

Merging #134 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #134   +/-   ##
=========================================
  Coverage     78.37%   78.37%           
  Complexity      302      302           
=========================================
  Files            21       21           
  Lines          2719     2719           
  Branches        134      134           
=========================================
  Hits           2131     2131           
  Misses          513      513           
  Partials         75       75           
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/google/cloud/pubsub/v1/Publisher.java 87.96% <ø> (ø) 46.00 <0.00> (ø)
...in/java/com/google/cloud/pubsub/v1/Subscriber.java 80.00% <ø> (ø) 22.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29e26ea...c4039ce. Read the comment docs.

@dpcollins-google dpcollins-google merged commit 89fcc88 into googleapis:master Apr 10, 2020
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants