Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update libraries-bom #140

Merged
merged 1 commit into from Apr 10, 2020
Merged

docs: update libraries-bom #140

merged 1 commit into from Apr 10, 2020

Conversation

anguillanneuf
Copy link
Contributor

@anguillanneuf anguillanneuf commented Apr 10, 2020

Is the libraries-bom update automated in any way? I suspect our docs page reads directly from here.

The tests took over hours to finish. Is there a way to skip some of these tests for README changes?

@googlebot googlebot added the cla: yes label Apr 10, 2020
@anguillanneuf anguillanneuf changed the title Update libraries-bom docs: update libraries-bom Apr 10, 2020
@codecov
Copy link

@codecov codecov bot commented Apr 10, 2020

Codecov Report

Merging #140 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #140   +/-   ##
=========================================
  Coverage     78.37%   78.37%           
  Complexity      302      302           
=========================================
  Files            21       21           
  Lines          2719     2719           
  Branches        134      134           
=========================================
  Hits           2131     2131           
  Misses          513      513           
  Partials         75       75           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29e26ea...b991726. Read the comment docs.

elharo
elharo approved these changes Apr 10, 2020
elharo
elharo approved these changes Apr 10, 2020
Copy link
Contributor

@elharo elharo left a comment

Thanks. It should be auto-updated but sometimes the autoupdater seems to miss things.

There's no way to skip the tests. You'd be surprised the bugs a simple change in the README can uncover.

@anguillanneuf anguillanneuf added type: docs kokoro:force-run labels Apr 10, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Apr 10, 2020
@anguillanneuf
Copy link
Contributor Author

@anguillanneuf anguillanneuf commented Apr 10, 2020

@elharo Thanks for approving the PR. I started a rerun to see if they will pass this time.
Could you point me to the autoupdater so I could take a look for this library?

Looks like Kokoro - Test: Java 8 is the problem. Looking at the log, is com.google.cloud.pubsub.v1.PublisherImplTest the issue?

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running com.google.cloud.pubsub.v1.SubscriptionAdminClientTest
[INFO] Tests run: 36, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.356 s - in com.google.cloud.pubsub.v1.SubscriptionAdminClientTest
[INFO] Running com.google.cloud.pubsub.v1.PublisherImplTest


ERROR: Aborting VM command due to timeout of 10800 seconds

@elharo
Copy link
Contributor

@elharo elharo commented Apr 10, 2020

You can ask @chingor13 about the auto-updater.

@elharo elharo added kokoro:run kokoro:force-run labels Apr 10, 2020
@yoshi-kokoro yoshi-kokoro removed kokoro:run kokoro:force-run labels Apr 10, 2020
@anguillanneuf anguillanneuf merged commit d8239bd into master Apr 10, 2020
14 checks passed
@anguillanneuf anguillanneuf deleted the anguillanneuf-patch-1 branch Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes type: docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants