Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changing integration test push endpoint to be valid https #170

Merged
merged 25 commits into from Apr 29, 2020

Conversation

hannahrogers-google
Copy link
Contributor

@hannahrogers-google hannahrogers-google commented Apr 29, 2020

Push endpoints should be of valid https format.

Adding delivery attempt count to PubsubMessages as a message attribute,
and creating helper function to allow users to get the count without
knowing implementation details.
@googlebot googlebot added the cla: yes label Apr 29, 2020
@codecov
Copy link

@codecov codecov bot commented Apr 29, 2020

Codecov Report

Merging #170 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #170   +/-   ##
=========================================
  Coverage     78.37%   78.37%           
  Complexity      302      302           
=========================================
  Files            21       21           
  Lines          2719     2719           
  Branches        134      134           
=========================================
  Hits           2131     2131           
  Misses          513      513           
  Partials         75       75           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6346042...9a6381d. Read the comment docs.

@kamalaboulhosn kamalaboulhosn merged commit 71f15a4 into googleapis:master Apr 29, 2020
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants