-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: changing integration test push endpoint to be valid https #170
Merged
kamalaboulhosn
merged 25 commits into
googleapis:master
from
hannahrogers-google:master
Apr 29, 2020
Merged
fix: changing integration test push endpoint to be valid https #170
kamalaboulhosn
merged 25 commits into
googleapis:master
from
hannahrogers-google:master
Apr 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding delivery attempt count to PubsubMessages as a message attribute, and creating helper function to allow users to get the count without knowing implementation details.
lettering is not enabled
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Apr 29, 2020
Codecov Report
@@ Coverage Diff @@
## master #170 +/- ##
=========================================
Coverage 78.37% 78.37%
Complexity 302 302
=========================================
Files 21 21
Lines 2719 2719
Branches 134 134
=========================================
Hits 2131 2131
Misses 513 513
Partials 75 75 Continue to review full report at Codecov.
|
kamalaboulhosn
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Push endpoints should be of valid https format.