Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set up repo for samples #196

Merged
merged 8 commits into from May 19, 2020
Merged

feat: set up repo for samples #196

merged 8 commits into from May 19, 2020

Conversation

anguillanneuf
Copy link
Contributor

@anguillanneuf anguillanneuf commented May 19, 2020

Modified these files to set up samples testing. A follow-up PR (#197) will add samples & tests.

        new file:   .kokoro/continuous/java11-samples.cfg
        new file:   .kokoro/continuous/jave8-samples.cfg
        new file:   .kokoro/nightly/java11-samples.cfg
        new file:   .kokoro/nightly/jave8-samples.cfg
        new file:   .kokoro/presubmit/java11-samples.cfg
        new file:   .kokoro/presubmit/jave8-samples.cfg
        new file:   .kokoro/run_samples_tests.sh
        modified:   pom.xml

@googlebot googlebot added the cla: yes label May 19, 2020
@codecov
Copy link

@codecov codecov bot commented May 19, 2020

Codecov Report

Merging #196 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #196   +/-   ##
=========================================
  Coverage     78.88%   78.88%           
  Complexity      302      302           
=========================================
  Files            21       21           
  Lines          2719     2719           
  Branches        150      150           
=========================================
  Hits           2145     2145           
  Misses          513      513           
  Partials         61       61           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87e036e...8fc8080. Read the comment docs.

@anguillanneuf anguillanneuf merged commit 3e1b136 into master May 19, 2020
22 checks passed
@anguillanneuf anguillanneuf deleted the samples-setup branch May 19, 2020
key: "TRAMPOLINE_BUILD_FILE"
value: "github/java-pubsub/.kokoro/run_samples_tests.sh"
}
© 2020 GitHub, Inc.
Copy link
Contributor

@chingor13 chingor13 May 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a typo

Copy link
Contributor Author

@anguillanneuf anguillanneuf May 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no, I need to take it out.

Copy link
Contributor Author

@anguillanneuf anguillanneuf May 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review #201

key: "TRAMPOLINE_BUILD_FILE"
value: "github/java-pubsub/.kokoro/run_samples_tests.sh"
}
© 2020 GitHub, Inc.
Copy link
Contributor

@chingor13 chingor13 May 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo?

key: "TRAMPOLINE_BUILD_FILE"
value: "github/java-pubsub/.kokoro/run_samples_tests.sh"
}
© 2020 GitHub, Inc.
Copy link
Contributor

@chingor13 chingor13 May 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants