Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement google-cloud-shared-dependencies BOM #198

Merged
merged 2 commits into from May 20, 2020

Conversation

stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented May 19, 2020

No description provided.

@googlebot googlebot added the cla: yes label May 19, 2020
@stephaniewang526 stephaniewang526 added the kokoro:force-run label May 19, 2020
@codecov
Copy link

@codecov codecov bot commented May 19, 2020

Codecov Report

Merging #198 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #198   +/-   ##
=========================================
  Coverage     78.88%   78.88%           
  Complexity      302      302           
=========================================
  Files            21       21           
  Lines          2719     2719           
  Branches        150      150           
=========================================
  Hits           2145     2145           
  Misses          513      513           
  Partials         61       61           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87e036e...a880009. Read the comment docs.

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label May 19, 2020
Copy link
Contributor

@anguillanneuf anguillanneuf left a comment

LGTM. Will approve after #204 gets merged so all tests can be run.

@anguillanneuf anguillanneuf self-requested a review May 20, 2020
@anguillanneuf anguillanneuf added the kokoro:force-run label May 20, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label May 20, 2020
@stephaniewang526 stephaniewang526 merged commit 55bdc26 into googleapis:master May 20, 2020
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants