Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update ignored diffs #206

Merged

Conversation

hannahrogers-google
Copy link
Contributor

@hannahrogers-google hannahrogers-google commented May 24, 2020

Ignoring Beta methods toStrings and parse in clirr check

Adding delivery attempt count to PubsubMessages as a message attribute,
and creating helper function to allow users to get the count without
knowing implementation details.
@googlebot googlebot added the cla: yes label May 24, 2020
@hannahrogers-google hannahrogers-google changed the title Update ignored diffs fix: update ignored diffs May 24, 2020
@codecov
Copy link

@codecov codecov bot commented May 24, 2020

Codecov Report

Merging #206 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #206   +/-   ##
=========================================
  Coverage     78.88%   78.88%           
  Complexity      302      302           
=========================================
  Files            21       21           
  Lines          2719     2719           
  Branches        150      150           
=========================================
  Hits           2145     2145           
  Misses          513      513           
  Partials         61       61           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a6c8c0...077f055. Read the comment docs.

Copy link
Contributor

@chingor13 chingor13 left a comment

Note that this addition can be removed after the next release.

@hannahrogers-google
Copy link
Contributor Author

@hannahrogers-google hannahrogers-google commented May 24, 2020

Note that this addition can be removed after the next release.

Thanks! Yes, I will remove this after the next release

@hannahrogers-google hannahrogers-google merged commit 240e141 into googleapis:master May 24, 2020
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants