Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement max duration per ack extension #211

Merged
merged 30 commits into from
Jul 6, 2020
Merged

feat: implement max duration per ack extension #211

merged 30 commits into from
Jul 6, 2020

Conversation

hannahrogers-google
Copy link
Contributor

Fixes #93

@hannahrogers-google
Modifying Publish example in README to match other examples given, and
19dd129 
fix issue #6784
@hannahrogers-google
fix: Modifying Publish example in README to match other examples, and
4158529 
fix Issue googleapis#11
@hannahrogers-google
Merge branch 'master' of github.com:hannahrogers-google/java-pubsub
7d704f0
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
9e0ebc6
@hannahrogers-google
feat: Adding support for DLQs
01d41b7 
Adding delivery attempt count to PubsubMessages as a message attribute,
and creating helper function to allow users to get the count without
knowing implementation details.
@hannahrogers-google
Fix formatting
ed3b1ee
@hannahrogers-google
fix: making changes requested in pull request
72f7996
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
389cb86
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
c9e4bd2
@hannahrogers-google
fix: creating fix to not populate delivery attempt attribute when dead
3738ec8 
lettering is not enabled
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
4ce1d3b
@hannahrogers-google
Adding unit test for case in which a received message has no delivery…
aecd4ca 
… attempt
@hannahrogers-google
Making MessageWaiter class more generic to also be used for outstanding
77fa3b3 
ack operations
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
b87023c
@hannahrogers-google
Merge branch 'master' into fix-subscriber-stop
7086b3c
@hannahrogers-google
Waiting for acks to complete before shutting down a streaming subscriber
da0e355 
connection
@hannahrogers-google
Fixing formatting error
dc55fc1
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
45beee2
@hannahrogers-google
fix: making sure all publishes complete before shutting down the
548b7a7 
publisher
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
76a1de9
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
a8989f1
@hannahrogers-google
adding default max outstanding request bytes
b4439fd
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
01f607c
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
c0cddb3
@hannahrogers-google
fix: make push endpoint valid https
9a6381d
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
0bd165f
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
5d47be8
@hannahrogers-google
feat: implement max duration per ack extension
9d6b53d
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 25, 2020
@codecov
Copy link

codecov bot commented May 25, 2020 •
edited
Loading

Codecov Report

Merging #211 into master will decrease coverage by 0.01%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #211      +/-   ##
============================================
- Coverage     79.05%   79.04%   -0.02%     
- Complexity      312      313       +1     
============================================
  Files            21       21              
  Lines          2841     2849       +8     
  Branches        153      155       +2     
============================================
+ Hits           2246     2252       +6     
  Misses          533      533              
- Partials         62       64       +2
Impacted Files Coverage Δ Complexity Δ
...cloud/pubsub/v1/StreamingSubscriberConnection.java 64.39% <ø> (ø) 9.00 <0.00> (ø)
.../com/google/cloud/pubsub/v1/MessageDispatcher.java 84.87% <66.66%> (-0.28%) 26.00 <0.00> (+1.00) ⬇️
...in/java/com/google/cloud/pubsub/v1/Subscriber.java 80.00% <80.00%> (ø) 22.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15f71ed...284a650. Read the comment docs.

@hannahrogers-google
Copy link
Contributor Author

@kamalaboulhosn, friendly ping - can you take another look at this?

@kamalaboulhosn
Copy link
Contributor

Apologies, this wasn't showing up in my list of pending reviews.

@hannahrogers-google hannahrogers-google merged commit 1427b8c into googleapis:master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamalaboulhosn kamalaboulhosn kamalaboulhosn approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pubsub: expose a MaxDurationPerAckExtension setting for subscribers
3 participants
@hannahrogers-google @kamalaboulhosn @googlebot