Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement max duration per ack extension #211

Merged

Conversation

hannahrogers-google
Copy link
Contributor

@hannahrogers-google hannahrogers-google commented May 25, 2020

Fixes #93

Adding delivery attempt count to PubsubMessages as a message attribute,
and creating helper function to allow users to get the count without
knowing implementation details.
@googlebot googlebot added the cla: yes label May 25, 2020
@codecov
Copy link

@codecov codecov bot commented May 25, 2020

Codecov Report

Merging #211 into master will decrease coverage by 0.01%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #211      +/-   ##
============================================
- Coverage     79.05%   79.04%   -0.02%     
- Complexity      312      313       +1     
============================================
  Files            21       21              
  Lines          2841     2849       +8     
  Branches        153      155       +2     
============================================
+ Hits           2246     2252       +6     
  Misses          533      533              
- Partials         62       64       +2     
Impacted Files Coverage Δ Complexity Δ
...cloud/pubsub/v1/StreamingSubscriberConnection.java 64.39% <ø> (ø) 9.00 <0.00> (ø)
.../com/google/cloud/pubsub/v1/MessageDispatcher.java 84.87% <66.66%> (-0.28%) 26.00 <0.00> (+1.00) ⬇️
...in/java/com/google/cloud/pubsub/v1/Subscriber.java 80.00% <80.00%> (ø) 22.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15f71ed...284a650. Read the comment docs.

@hannahrogers-google
Copy link
Contributor Author

@hannahrogers-google hannahrogers-google commented Jun 24, 2020

@kamalaboulhosn, friendly ping - can you take another look at this?

@kamalaboulhosn
Copy link
Contributor

@kamalaboulhosn kamalaboulhosn commented Jul 6, 2020

Apologies, this wasn't showing up in my list of pending reviews.

@hannahrogers-google hannahrogers-google merged commit 1427b8c into googleapis:master Jul 6, 2020
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants