Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add detach subscription rpc #216

Merged
merged 3 commits into from Jun 5, 2020
Merged

feat: add detach subscription rpc #216

merged 3 commits into from Jun 5, 2020

Conversation

yoshi-automation
Copy link
Contributor

@yoshi-automation yoshi-automation commented May 26, 2020

This PR was generated using Autosynth. 馃寛

Synth log will be available here:
https://source.cloud.google.com/results/invocations/3f2d59a9-201f-4a67-b247-7356a3ac82ae/targets

PiperOrigin-RevId: 313276022
Source-Link: googleapis/googleapis@f5f268f

        autosynth cannot find the source of changes triggered by earlier changes in this
        repository, or by version upgrades to tools such as linters.
PiperOrigin-RevId: 313276022

Source-Author: Google APIs <noreply@google.com>
Source-Date: Tue May 26 15:11:32 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: f5f268f5293e60143ac742a4eeb7dd6306ebf505
Source-Link: googleapis/googleapis@f5f268f
@googlebot googlebot added the cla: yes label May 26, 2020
@codecov
Copy link

@codecov codecov bot commented May 26, 2020

Codecov Report

Merging #216 into master will increase coverage by 0.12%.
The diff coverage is 89.18%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #216      +/-   ##
============================================
+ Coverage     79.05%   79.17%   +0.12%     
- Complexity      312      316       +4     
============================================
  Files            21       21              
  Lines          2841     2877      +36     
  Branches        153      153              
============================================
+ Hits           2246     2278      +32     
- Misses          533      537       +4     
  Partials         62       62              
Impacted Files Coverage 螖 Complexity 螖
...com/google/cloud/pubsub/v1/TopicAdminSettings.java 19.60% <0.00%> (-0.81%) 5.00 <0.00> (酶)
...com/google/cloud/pubsub/v1/stub/PublisherStub.java 6.25% <0.00%> (-0.42%) 1.00 <0.00> (酶)
...le/cloud/pubsub/v1/stub/PublisherStubSettings.java 83.56% <90.90%> (+0.29%) 21.00 <1.00> (+1.00)
...a/com/google/cloud/pubsub/v1/TopicAdminClient.java 58.95% <100.00%> (+0.48%) 34.00 <2.00> (+2.00)
...google/cloud/pubsub/v1/stub/GrpcPublisherStub.java 96.09% <100.00%> (+0.33%) 19.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 8414ee7...dfa182f. Read the comment docs.

@hannahrogers-google hannahrogers-google changed the title Add DetachSubscription RPC feat: add detach subscription rpc May 27, 2020
Copy link
Contributor

@anguillanneuf anguillanneuf left a comment

I only had to resolve a merge conflict in synth.metadata.

@anguillanneuf anguillanneuf merged commit 09866b0 into master Jun 5, 2020
16 checks passed
@anguillanneuf anguillanneuf deleted the autosynth-googleapis branch Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes context: partial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants