Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump shared-deps version and add back certain test deps #218

Merged
merged 1 commit into from May 27, 2020

Conversation

stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented May 27, 2020

No description provided.

@googlebot googlebot added the cla: yes label May 27, 2020
</dependency>
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>grpc-google-iam-v1</artifactId>
Copy link
Contributor

@chingor13 chingor13 May 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this one necessary?

Copy link
Member Author

@stephaniewang526 stephaniewang526 May 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe so - it was there originally

@codecov
Copy link

@codecov codecov bot commented May 27, 2020

Codecov Report

Merging #218 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #218   +/-   ##
=========================================
  Coverage     79.05%   79.05%           
  Complexity      312      312           
=========================================
  Files            21       21           
  Lines          2841     2841           
  Branches        153      153           
=========================================
  Hits           2246     2246           
  Misses          533      533           
  Partials         62       62           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48fb400...41080fe. Read the comment docs.

@stephaniewang526 stephaniewang526 added the automerge label May 27, 2020
@stephaniewang526 stephaniewang526 merged commit 49ecc69 into googleapis:master May 27, 2020
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants