Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: remove grpc test dep since it's now in shared-deps #220

Merged

Conversation

stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented May 28, 2020

grpc-iam-v1 added in shared-deps v0.6.0

@googlebot googlebot added the cla: yes label May 28, 2020
@stephaniewang526 stephaniewang526 added the automerge label May 28, 2020
@codecov
Copy link

@codecov codecov bot commented May 28, 2020

Codecov Report

Merging #220 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #220   +/-   ##
=========================================
  Coverage     79.05%   79.05%           
  Complexity      312      312           
=========================================
  Files            21       21           
  Lines          2841     2841           
  Branches        153      153           
=========================================
  Hits           2246     2246           
  Misses          533      533           
  Partials         62       62           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49ecc69...c5f81cf. Read the comment docs.

@gcf-merge-on-green
Copy link

@gcf-merge-on-green gcf-merge-on-green bot commented May 28, 2020

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

1 similar comment
@gcf-merge-on-green
Copy link

@gcf-merge-on-green gcf-merge-on-green bot commented May 28, 2020

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link

@gcf-merge-on-green gcf-merge-on-green bot commented May 28, 2020

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

Copy link
Contributor

@anguillanneuf anguillanneuf left a comment

Approve because all tests are passing.

What was grpc-google-aim-v1 used for?

@stephaniewang526
Copy link
Member Author

@stephaniewang526 stephaniewang526 commented May 28, 2020

It is used for testing.

@stephaniewang526 stephaniewang526 merged commit 28ab521 into googleapis:master May 28, 2020
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants