Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make error message more clear about where ordering must be enabled when publishing #293

Merged
merged 11 commits into from Jul 24, 2020

Conversation

kamalaboulhosn
Copy link
Contributor

@kamalaboulhosn kamalaboulhosn commented Jul 23, 2020

No description provided.

@google-cla google-cla bot added the cla: yes label Jul 23, 2020
@codecov
Copy link

@codecov codecov bot commented Jul 23, 2020

Codecov Report

Merging #293 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #293      +/-   ##
============================================
+ Coverage     79.18%   79.22%   +0.03%     
  Complexity      317      317              
============================================
  Files            21       21              
  Lines          2888     2888              
  Branches        155      155              
============================================
+ Hits           2287     2288       +1     
  Misses          537      537              
+ Partials         64       63       -1     
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/google/cloud/pubsub/v1/Publisher.java 87.96% <ø> (ø) 46.00 <0.00> (ø)
.../com/google/cloud/pubsub/v1/MessageDispatcher.java 85.36% <0.00%> (+0.48%) 26.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8f981b...78ab82d. Read the comment docs.

@kamalaboulhosn kamalaboulhosn changed the title fix: Make error message more clear about where ordering must be enabled when publishing. fix: Make error message more clear about where ordering must be enabled when publishing Jul 23, 2020
@hannahrogers-google hannahrogers-google added the kokoro:force-run label Jul 23, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jul 23, 2020
@kamalaboulhosn kamalaboulhosn merged commit f54ed02 into googleapis:master Jul 24, 2020
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants