-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Ensure that messages that are in pending batches for an ordering key are canceled when a previous publish for the ordering keys fails #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9c113c3.
…ed when publishing.
… key are canceled when a previous publish for the ordering keys fails.
kamalaboulhosn
changed the title
fix: Ensure that messages that are in pending batches for an ordering key are canceled when a previous publish for the ordering keys fails.
fix: Ensure that messages that are in pending batches for an ordering key are canceled when a previous publish for the ordering keys fails
Sep 27, 2020
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Sep 27, 2020
Codecov Report
@@ Coverage Diff @@
## master #366 +/- ##
============================================
- Coverage 79.21% 79.20% -0.02%
- Complexity 318 319 +1
============================================
Files 21 21
Lines 2892 2905 +13
Branches 155 159 +4
============================================
+ Hits 2291 2301 +10
- Misses 536 537 +1
- Partials 65 67 +2
Continue to review full report at Codecov.
|
product-auto-label
bot
added
the
api: pubsub
Issues related to the googleapis/java-pubsub API.
label
Sep 28, 2020
hannahrogers-google
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: pubsub
Issues related to the googleapis/java-pubsub API.
cla: yes
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #365