Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure that messages that are in pending batches for an ordering key are canceled when a previous publish for the ordering keys fails #366

Merged
merged 13 commits into from Sep 29, 2020

Conversation

kamalaboulhosn
Copy link
Contributor

@kamalaboulhosn kamalaboulhosn commented Sep 27, 2020

Fixes #365

@kamalaboulhosn kamalaboulhosn requested a review from as a code owner Sep 27, 2020
@kamalaboulhosn kamalaboulhosn changed the title fix: Ensure that messages that are in pending batches for an ordering key are canceled when a previous publish for the ordering keys fails. fix: Ensure that messages that are in pending batches for an ordering key are canceled when a previous publish for the ordering keys fails Sep 27, 2020
@google-cla google-cla bot added the cla: yes label Sep 27, 2020
@codecov
Copy link

@codecov codecov bot commented Sep 27, 2020

Codecov Report

Merging #366 into master will decrease coverage by 0.01%.
The diff coverage is 92.30%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #366      +/-   ##
============================================
- Coverage     79.21%   79.20%   -0.02%     
- Complexity      318      319       +1     
============================================
  Files            21       21              
  Lines          2892     2905      +13     
  Branches        155      159       +4     
============================================
+ Hits           2291     2301      +10     
- Misses          536      537       +1     
- Partials         65       67       +2     
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/google/cloud/pubsub/v1/Publisher.java 87.13% <91.66%> (-0.37%) 46.00 <0.00> (+1.00) ⬇️
...gle/cloud/pubsub/v1/SequentialExecutorService.java 91.11% <100.00%> (+0.09%) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a988b19...8b73467. Read the comment docs.

@product-auto-label product-auto-label bot added the api: pubsub label Sep 28, 2020
@kamalaboulhosn kamalaboulhosn merged commit 7cdf8bc into googleapis:master Sep 29, 2020
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants