Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Document potentially unexpected blocking behavior of publish() method #370

Merged
merged 2 commits into from Jan 21, 2021

Conversation

dpcollins-google
Copy link
Contributor

@dpcollins-google dpcollins-google commented Sep 30, 2020

No description provided.

@dpcollins-google dpcollins-google requested a review from as a code owner Sep 30, 2020
@google-cla google-cla bot added the cla: yes label Sep 30, 2020
Copy link
Contributor

@anguillanneuf anguillanneuf left a comment

Same here. Your commit message doesn't conform to conventional commits.

@codecov
Copy link

@codecov codecov bot commented Sep 30, 2020

Codecov Report

Merging #370 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #370   +/-   ##
=========================================
  Coverage     79.20%   79.20%           
  Complexity      320      320           
=========================================
  Files            21       21           
  Lines          2905     2905           
  Branches        159      159           
=========================================
  Hits           2301     2301           
  Misses          537      537           
  Partials         67       67           
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/google/cloud/pubsub/v1/Publisher.java 87.13% <ø> (ø) 47.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cb744c...f655d0f. Read the comment docs.

@product-auto-label product-auto-label bot added the api: pubsub label Oct 1, 2020
@meredithslota meredithslota changed the title docs: Document potentially unexpected blocking behavior of publish() method. docs: Document potentially unexpected blocking behavior of publish() method Jan 21, 2021
@anguillanneuf anguillanneuf merged commit 18b3a2f into master Jan 21, 2021
19 checks passed
@anguillanneuf anguillanneuf deleted the docs-publish-block branch Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants