Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make the stream ack deadline congruent with maxDurationPerAckExtension #447

Merged
merged 7 commits into from Nov 23, 2020

Conversation

beltran
Copy link
Contributor

@beltran beltran commented Nov 20, 2020

Fixes #446 ☕️

@beltran beltran requested a review from as a code owner Nov 20, 2020
@product-auto-label product-auto-label bot added the api: pubsub label Nov 20, 2020
@google-cla google-cla bot added the cla: yes label Nov 20, 2020
@codecov
Copy link

@codecov codecov bot commented Nov 20, 2020

Codecov Report

Merging #447 (29760b0) into master (c92c7fd) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #447      +/-   ##
============================================
+ Coverage     79.06%   79.14%   +0.07%     
- Complexity      320      323       +3     
============================================
  Files            21       21              
  Lines          2914     2925      +11     
  Branches        163      166       +3     
============================================
+ Hits           2304     2315      +11     
  Misses          541      541              
  Partials         69       69              
Impacted Files Coverage Δ Complexity Δ
...cloud/pubsub/v1/StreamingSubscriberConnection.java 66.66% <100.00%> (+2.33%) 14.00 <0.00> (+3.00)
...in/java/com/google/cloud/pubsub/v1/Subscriber.java 80.51% <100.00%> (+0.10%) 22.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c92c7fd...29760b0. Read the comment docs.

@beltran beltran changed the title feat: allow to override the stream ack deadline feat: make the stream ack deadline congruent with maxDurationPerAckExtension Nov 23, 2020
@kamalaboulhosn kamalaboulhosn added the kokoro:force-run label Nov 23, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Nov 23, 2020
@kamalaboulhosn kamalaboulhosn merged commit c63dc25 into googleapis:master Nov 23, 2020
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants