Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding deprecated tags to deprecated methods #472

Merged
merged 45 commits into from Jan 21, 2021

Conversation

hannahrogers-google
Copy link
Contributor

@hannahrogers-google hannahrogers-google commented Dec 23, 2020

Fixes #249 ☕️

Adding delivery attempt count to PubsubMessages as a message attribute,
and creating helper function to allow users to get the count without
knowing implementation details.
@product-auto-label product-auto-label bot added the api: pubsub label Dec 23, 2020
@google-cla google-cla bot added the cla: yes label Dec 23, 2020
@codecov
Copy link

@codecov codecov bot commented Dec 23, 2020

Codecov Report

Merging #472 (9ac49ea) into master (260eca5) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #472      +/-   ##
============================================
- Coverage     79.17%   79.14%   -0.04%     
  Complexity      323      323              
============================================
  Files            21       21              
  Lines          2925     2925              
  Branches        166      166              
============================================
- Hits           2316     2315       -1     
  Misses          541      541              
- Partials         68       69       +1     
Impacted Files Coverage Δ Complexity Δ
.../com/google/cloud/pubsub/v1/MessageDispatcher.java 84.87% <0.00%> (-0.49%) 26.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 260eca5...9ac49ea. Read the comment docs.

@hannahrogers-google hannahrogers-google requested a review from Jan 6, 2021
@stephaniewang526 stephaniewang526 requested review from chingor13 and removed request for stephaniewang526 Jan 21, 2021
elharo
elharo approved these changes Jan 21, 2021
@elharo elharo merged commit 91b5152 into googleapis:master Jan 21, 2021
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants