Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix flakiness in subscriberIT integration test #476

Merged

Conversation

hannahrogers-google
Copy link
Contributor

@hannahrogers-google hannahrogers-google commented Jan 6, 2021

The subscriber sync pull integration test is still flaky because the PullRequest does not always return the max amount of messages requested. Adding retries to the synchronous pull operations to ensure all messages are received.

Fixes #435 ☕️

Adding delivery attempt count to PubsubMessages as a message attribute,
and creating helper function to allow users to get the count without
knowing implementation details.
@hannahrogers-google hannahrogers-google requested a review from Jan 6, 2021
@product-auto-label product-auto-label bot added the api: pubsub label Jan 6, 2021
@google-cla google-cla bot added the cla: yes label Jan 6, 2021
@hannahrogers-google hannahrogers-google changed the title fix: fix flakinessijmn fix: fix flakiness in subscriberIT integration test Jan 6, 2021
@codecov
Copy link

@codecov codecov bot commented Jan 6, 2021

Codecov Report

Merging #476 (d185e92) into master (3006332) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #476   +/-   ##
=========================================
  Coverage     79.17%   79.17%           
  Complexity      323      323           
=========================================
  Files            21       21           
  Lines          2925     2925           
  Branches        166      166           
=========================================
  Hits           2316     2316           
  Misses          541      541           
  Partials         68       68           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3006332...d185e92. Read the comment docs.

Copy link
Contributor

@anguillanneuf anguillanneuf left a comment

Looks much better than what I had. Thank you!

@hannahrogers-google hannahrogers-google merged commit d981b4e into googleapis:master Jan 12, 2021
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants