Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly shutdown subscriber stub on permanent streaming pull failure #539

Merged

Conversation

hannahrogers-google
Copy link
Contributor

@hannahrogers-google hannahrogers-google commented Feb 25, 2021

When a subscriber fails permanently, we are not shutting down the stub, like we do during a normal shutdown. Making a change to shut down the subscriber stub on failure. Before shutting down the subscriber stub, we must first shut down the MessageDispatcher to verifying that all acks are processed first.

Fixes #315 ☕️

Adding delivery attempt count to PubsubMessages as a message attribute,
and creating helper function to allow users to get the count without
knowing implementation details.
@hannahrogers-google hannahrogers-google requested a review from as a code owner Feb 25, 2021
@product-auto-label product-auto-label bot added the api: pubsub label Feb 25, 2021
@google-cla google-cla bot added the cla: yes label Feb 25, 2021
@codecov
Copy link

@codecov codecov bot commented Feb 25, 2021

Codecov Report

Merging #539 (f80de80) into master (d8728e9) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #539      +/-   ##
============================================
+ Coverage     78.79%   78.81%   +0.02%     
- Complexity      376      378       +2     
============================================
  Files            27       27              
  Lines          3414     3418       +4     
  Branches        171      171              
============================================
+ Hits           2690     2694       +4     
  Misses          651      651              
  Partials         73       73              
Impacted Files Coverage Δ Complexity Δ
...cloud/pubsub/v1/StreamingSubscriberConnection.java 67.30% <100.00%> (+0.64%) 15.00 <2.00> (+1.00)
...in/java/com/google/cloud/pubsub/v1/Subscriber.java 80.61% <100.00%> (+0.09%) 23.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8728e9...efd0fa1. Read the comment docs.

@hannahrogers-google hannahrogers-google merged commit adbcc0c into googleapis:master Mar 3, 2021
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub cla: yes
Projects
None yet
2 participants