Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding support for dead letter queues #60

Merged
merged 8 commits into from Jan 14, 2020

Conversation

hannahrogers-google
Copy link
Contributor

@hannahrogers-google hannahrogers-google commented Jan 13, 2020

Adding delivery attempt count to PubsubMessages as a message attribute, and creating helper function to allow users to get the count without knowing implementation details.

@googlebot googlebot added the cla: yes label Jan 13, 2020
@hannahrogers-google hannahrogers-google changed the title feat: Adding support for DLQs feat: adding support for dead letter queues Jan 13, 2020
@codecov
Copy link

@codecov codecov bot commented Jan 13, 2020

Codecov Report

Merging #60 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #60   +/-   ##
========================================
  Coverage      78.9%   78.9%           
  Complexity      290     290           
========================================
  Files            21      21           
  Lines          2583    2583           
  Branches        128     128           
========================================
  Hits           2038    2038           
  Misses          490     490           
  Partials         55      55

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72f7996...389cb86. Read the comment docs.

@maheshgattani maheshgattani requested review from maheshgattani and removed request for kamalaboulhosn Jan 13, 2020
Copy link

@maheshgattani maheshgattani left a comment

Looking good. Left a couple of comments.

Copy link

@maheshgattani maheshgattani left a comment

Looks good to me. Thanks.

@hannahrogers-google hannahrogers-google added the kokoro:force-run label Jan 14, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jan 14, 2020
@hannahrogers-google hannahrogers-google merged commit f3c93fa into googleapis:master Jan 14, 2020
13 checks passed
@hannahrogers-google
Copy link
Contributor Author

@hannahrogers-google hannahrogers-google commented Jan 21, 2020

Completes Feature Request #67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants