Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removing delivery attempt attribute when dead lettering is not enabled #72

Merged
merged 12 commits into from Jan 30, 2020

Conversation

hannahrogers-google
Copy link
Contributor

@hannahrogers-google hannahrogers-google commented Jan 29, 2020

Fixes #67

When DLQ is not enabled, the delivery attempt attribute should not be populated on a PubsubMessage. The static helper function to get the delivery attempt should return null if the attribute is not set.

@googlebot googlebot added the cla: yes label Jan 29, 2020
@codecov
Copy link

@codecov codecov bot commented Jan 29, 2020

Codecov Report

Merging #72 into master will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #72      +/-   ##
============================================
+ Coverage     78.82%   78.94%   +0.11%     
- Complexity      291      292       +1     
============================================
  Files            21       21              
  Lines          2588     2588              
  Branches        129      129              
============================================
+ Hits           2040     2043       +3     
+ Misses          491      490       -1     
+ Partials         57       55       -2
Impacted Files Coverage Δ Complexity Δ
.../com/google/cloud/pubsub/v1/MessageDispatcher.java 85.64% <ø> (+1.48%) 25 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3738ec8...aecd4ca. Read the comment docs.

@hannahrogers-google hannahrogers-google added the kokoro:force-run label Jan 29, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jan 29, 2020
@hannahrogers-google hannahrogers-google added the kokoro:force-run label Jan 30, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jan 30, 2020
@hannahrogers-google hannahrogers-google merged commit 535854d into googleapis:master Jan 30, 2020
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants