-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: shutdown grpc stubs properly when a subscriber is stopped #74
fix: shutdown grpc stubs properly when a subscriber is stopped #74
Conversation
Adding delivery attempt count to PubsubMessages as a message attribute, and creating helper function to allow users to get the count without knowing implementation details.
lettering is not enabled
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
============================================
- Coverage 78.94% 78.93% -0.01%
- Complexity 292 293 +1
============================================
Files 21 21
Lines 2588 2597 +9
Branches 129 129
============================================
+ Hits 2043 2050 +7
- Misses 490 492 +2
Partials 55 55
Continue to review full report at Codecov.
|
This PR modifies the code to do the following:
This PR should fix issue #22 and issue #28. Using the steps to reproduce the issue (provided in #28), I was able to confirm the problem. With this fix, I confirmed that the issue is no longer present. |
Fixes #22