fix: shutdown grpc stubs properly when a subscriber is stopped #74
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
lettering is not enabled
@@ Coverage Diff @@ ## master #74 +/- ## ============================================ - Coverage 78.94% 78.93% -0.01% - Complexity 292 293 +1 ============================================ Files 21 21 Lines 2588 2597 +9 Branches 129 129 ============================================ + Hits 2043 2050 +7 - Misses 490 492 +2 Partials 55 55
This PR modifies the code to do the following:
This PR should fix issue #22 and issue #28. Using the steps to reproduce the issue (provided in #28), I was able to confirm the problem. With this fix, I confirmed that the issue is no longer present.
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.