Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure all publishes complete before shutting down publisher #76

Merged

Conversation

hannahrogers-google
Copy link
Contributor

@hannahrogers-google hannahrogers-google commented Jan 31, 2020

Fixes #70

Adding delivery attempt count to PubsubMessages as a message attribute,
and creating helper function to allow users to get the count without
knowing implementation details.
@googlebot googlebot added the cla: yes label Jan 31, 2020
@codecov
Copy link

@codecov codecov bot commented Jan 31, 2020

Codecov Report

Merging #76 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #76      +/-   ##
============================================
+ Coverage     78.93%   78.94%   +<.01%     
  Complexity      293      293              
============================================
  Files            21       21              
  Lines          2597     2598       +1     
  Branches        129      129              
============================================
+ Hits           2050     2051       +1     
  Misses          492      492              
  Partials         55       55
Impacted Files Coverage Δ Complexity Δ
...oogle/cloud/pubsub/v1/SubscriptionAdminClient.java 66.18% <ø> (ø) 46 <0> (ø) ⬇️
...ain/java/com/google/cloud/pubsub/v1/Publisher.java 89.1% <100%> (+0.03%) 43 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc55fc1...548b7a7. Read the comment docs.

@kamalaboulhosn kamalaboulhosn merged commit d0ab525 into googleapis:master Jan 31, 2020
13 checks passed
@hannahrogers-google hannahrogers-google deleted the fix-publisher-shutdown branch Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants