Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add randomly generated UUID to outgoing initial streaming pull requests #77

Merged
merged 6 commits into from Jan 31, 2020
Merged

Conversation

kamalaboulhosn
Copy link
Contributor

@kamalaboulhosn kamalaboulhosn commented Jan 31, 2020

This improves key affinity for ordering keys.

@googlebot googlebot added the cla: yes label Jan 31, 2020
@codecov
Copy link

@codecov codecov bot commented Jan 31, 2020

Codecov Report

Merging #77 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #77      +/-   ##
============================================
+ Coverage      78.9%   78.96%   +0.05%     
- Complexity      292      293       +1     
============================================
  Files            21       21              
  Lines          2588     2600      +12     
  Branches        129      129              
============================================
+ Hits           2042     2053      +11     
- Misses          490      492       +2     
+ Partials         56       55       -1
Impacted Files Coverage Δ Complexity Δ
...cloud/pubsub/v1/StreamingSubscriberConnection.java 64.39% <100%> (-0.37%) 9 <0> (ø)
...java/com/google/cloud/pubsub/v1/MessageWaiter.java
...c/main/java/com/google/cloud/pubsub/v1/Waiter.java 76.47% <0%> (ø) 6% <0%> (?)
...ain/java/com/google/cloud/pubsub/v1/Publisher.java 89.1% <0%> (+0.03%) 43% <0%> (ø) ⬇️
...in/java/com/google/cloud/pubsub/v1/Subscriber.java 79.67% <0%> (+0.11%) 22% <0%> (ø) ⬇️
.../com/google/cloud/pubsub/v1/MessageDispatcher.java 85.64% <0%> (+0.49%) 25% <0%> (ø) ⬇️
...oogle/cloud/pubsub/v1/stub/GrpcSubscriberStub.java 94.23% <0%> (+0.54%) 22% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 052ed86...ddd6920. Read the comment docs.

@hannahrogers-google hannahrogers-google added the kokoro:force-run label Jan 31, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants