Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(samples): add readme #849

Merged
merged 2 commits into from Sep 20, 2021
Merged

docs(samples): add readme #849

merged 2 commits into from Sep 20, 2021

Conversation

anguillanneuf
Copy link
Contributor

@anguillanneuf anguillanneuf commented Sep 20, 2021

Fixes #744

@anguillanneuf anguillanneuf requested review from as code owners Sep 20, 2021
@product-auto-label product-auto-label bot added the api: pubsub label Sep 20, 2021
@google-cla google-cla bot added the cla: yes label Sep 20, 2021
@product-auto-label product-auto-label bot added the samples label Sep 20, 2021
cd java-pubsub/samples/snippets
```

1. With [Maven] installed and the environment variable `GOOGLE_APPLICATION_CREDENTIALS` set to point to your [GCP service account] key file, run a sample that has the to-do section completed:
Copy link

@lesv lesv Sep 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still the right thing to ask? We don't really want them downloading SA's any more.

Copy link
Contributor Author

@anguillanneuf anguillanneuf Sep 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. Updated.

Copy link

@lesv lesv left a comment

use gcloud auth application-default login

@anguillanneuf anguillanneuf requested a review from lesv Sep 20, 2021
lesv
lesv approved these changes Sep 20, 2021
@anguillanneuf anguillanneuf merged commit 66135cf into master Sep 20, 2021
17 checks passed
@anguillanneuf anguillanneuf deleted the samples-readme branch Sep 20, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Sep 27, 2021
🤖 I have created a release \*beep\* \*boop\*
---
### [1.114.5](https://www.github.com/googleapis/java-pubsub/compare/v1.114.4...v1.114.5) (2021-09-27)


### Bug Fixes

* do not block forever if message size > flow control limits ([#847](https://www.github.com/googleapis/java-pubsub/issues/847)) ([f4ca4b2](https://www.github.com/googleapis/java-pubsub/commit/f4ca4b2d12730d5cef64d6f986b140de2c51147d))
* reset resource ids before test retries ([#852](https://www.github.com/googleapis/java-pubsub/issues/852)) ([3769e53](https://www.github.com/googleapis/java-pubsub/commit/3769e53225e1c4e32a1a0d5179c2a333258d69a8))


### Documentation

* **samples:** add readme ([#849](https://www.github.com/googleapis/java-pubsub/issues/849)) ([66135cf](https://www.github.com/googleapis/java-pubsub/commit/66135cf20c4d3c3ffc881b52f0273a14881ac97b))


### Dependencies

* update dependency com.google.cloud:google-cloud-core to v2.1.5 ([#854](https://www.github.com/googleapis/java-pubsub/issues/854)) ([374b8c3](https://www.github.com/googleapis/java-pubsub/commit/374b8c3f25aedd9ebdbb0d8075a201c482dadd40))
* update dependency com.google.cloud:google-cloud-core to v2.1.6 ([#855](https://www.github.com/googleapis/java-pubsub/issues/855)) ([9fabfc3](https://www.github.com/googleapis/java-pubsub/commit/9fabfc3177ebb08082557803801ade0e12e2e36d))
* update dependency com.google.cloud:google-cloud-core to v2.1.7 ([#858](https://www.github.com/googleapis/java-pubsub/issues/858)) ([2cd94b5](https://www.github.com/googleapis/java-pubsub/commit/2cd94b57529f683465c8fd969cbf4a435d214b60))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.3.0 ([#856](https://www.github.com/googleapis/java-pubsub/issues/856)) ([ab47c15](https://www.github.com/googleapis/java-pubsub/commit/ab47c15a92978fbc994ed2db02ad1f24ed640fd0))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub cla: yes samples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants