Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update dependency com.google.cloud:google-cloud-shared-dependencies to v2.4.0 #882

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Oct 18, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.google.cloud:google-cloud-shared-dependencies 2.3.0 -> 2.4.0 age adoption passing confidence

Release Notes

googleapis/java-shared-dependencies

v2.4.0

Compare Source

Dependencies
  • update dependency com.fasterxml.jackson:jackson-bom to v2.13.0 (dba11b5)
  • update dependency com.google.api-client:google-api-client-bom to v1.32.2 (dba11b5)
  • update dependency com.google.api:api-common to v2.0.5 (dba11b5)
  • update dependency com.google.auth:google-auth-library-bom to v1.2.1 (dba11b5)
  • update dependency com.google.guava:guava-bom to v31 (#​498) (dba11b5)
  • update dependency com.google.http-client:google-http-client-bom to v1.40.1 (dba11b5)
  • update dependency com.google.protobuf:protobuf-bom to v3.18.1 (#​494) (a30e376)
  • update dependency io.grpc:grpc-bom to v1.41.0 (#​482) (8a7d227)
  • update gax.version to v2.6.1 (dba11b5)
  • update iam.version to v1.1.6 (#​485) (cef7e09)

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate-bot renovate-bot requested review from as code owners Oct 18, 2021
@google-cla google-cla bot added the cla: yes label Oct 18, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run owlbot:run labels Oct 18, 2021
@product-auto-label product-auto-label bot added the api: pubsub label Oct 18, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Oct 18, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Oct 18, 2021
@Neenu1995 Neenu1995 added the automerge label Oct 18, 2021
@suztomo
Copy link
Member

@suztomo suztomo commented Oct 19, 2021

Just bumping the shared dependencies BOM version (5f395fa) failed at "ci / units (8)" and other places because package com.google.auth.oauth2 does not exist https://github.com/googleapis/java-pubsub/pull/882/checks?check_run_id=3932366398

[INFO] -------------------------------------------------------------
Error:  COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
Error:  /home/runner/work/java-pubsub/java-pubsub/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Subscriber.java:[37,30] package com.google.auth.oauth2 does not exist
[INFO] 1 error
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Google Cloud Pub/Sub Parent 1.114.7-SNAPSHOT ....... SUCCESS [  3.450 s]
[INFO] proto-google-cloud-pubsub-v1 1.96.7-SNAPSHOT ....... SUCCESS [  1.986 s]
[INFO] grpc-google-cloud-pubsub-v1 1.96.7-SNAPSHOT ........ SUCCESS [  0.928 s]
[INFO] Google Cloud Pub/Sub 1.114.7-SNAPSHOT .............. FAILURE [  1.832 s]
[INFO] Google Cloud pubsub BOM 1.114.7-SNAPSHOT ........... SUCCESS [  3.444 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------

We know it fails because the artifact google-auth-library-oauth2-http is now "runtime" scope of the project.

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run owlbot:run labels Oct 19, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Oct 19, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Oct 19, 2021
@suztomo
Copy link
Member

@suztomo suztomo commented Oct 19, 2021

Declaring the missing dependency of google-auth-library-oauth2-http (83783c0) fails at "ci / dependencies" https://github.com/googleapis/java-pubsub/pull/882/checks?check_run_id=3933525663 :

[INFO] --- maven-dependency-plugin:3.1.2:analyze (default-cli) @ google-cloud-pubsub ---
Warning:  Unused declared dependencies found:
Warning:     com.google.auth:google-auth-library-oauth2-http:jar:1.2.1:compile
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Google Cloud Pub/Sub Parent 1.114.7-SNAPSHOT ....... SUCCESS [  3.000 s]
[INFO] proto-google-cloud-pubsub-v1 1.96.7-SNAPSHOT ....... SUCCESS [  0.723 s]
[INFO] grpc-google-cloud-pubsub-v1 1.96.7-SNAPSHOT ........ SUCCESS [  0.132 s]
[INFO] Google Cloud Pub/Sub 1.114.7-SNAPSHOT .............. FAILURE [  0.497 s]
[INFO] Google Cloud pubsub BOM 1.114.7-SNAPSHOT ........... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------

This is unexpected because the artifact is used here:

Screen Shot 2021-10-18 at 4 54 11 PM

maven-dependency-plugin:3.1.2:analyze is from this command:

mvn -B dependency:analyze -DfailOnWarning=true

Copy link
Member

@suztomo suztomo left a comment

@chanseokoh This is the strange behavior of Maven dependency plugin. I appreciate your help!

@@ -61,7 +61,7 @@
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-shared-dependencies</artifactId>
<version>2.3.0</version>
<version>2.4.0</version>
Copy link
Member

@suztomo suztomo Oct 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before declaring google-auth-library-oauth2-http, this failed: package com.google.auth.oauth2 does not exist #882 (comment)

google-cloud-pubsub/pom.xml Show resolved Hide resolved
@Neenu1995 Neenu1995 added the kokoro:force-run label Oct 19, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Oct 19, 2021
@gcf-merge-on-green
Copy link

@gcf-merge-on-green gcf-merge-on-green bot commented Oct 19, 2021

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Oct 19, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run owlbot:run labels Oct 19, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Oct 19, 2021
@chanseokoh chanseokoh added the automerge label Oct 19, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Oct 19, 2021
@Neenu1995 Neenu1995 added the kokoro:force-run label Oct 19, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Oct 19, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run owlbot:run labels Oct 19, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Oct 19, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Oct 19, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run owlbot:run labels Oct 19, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Oct 19, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Oct 19, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 2c367bb into googleapis:main Oct 19, 2021
19 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Oct 19, 2021
@renovate-bot renovate-bot deleted the renovate/com.google.cloud-google-cloud-shared-dependencies-2.x branch Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants