-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update dependency com.google.cloud:google-cloud-shared-dependencies to v2.4.0 #882
deps: update dependency com.google.cloud:google-cloud-shared-dependencies to v2.4.0 #882
Conversation
Just bumping the shared dependencies BOM version (5f395fa) failed at "ci / units (8)" and other places because
We know it fails because the artifact google-auth-library-oauth2-http is now "runtime" scope of the project. |
Declaring the missing dependency of google-auth-library-oauth2-http (83783c0) fails at "ci / dependencies" https://github.com/googleapis/java-pubsub/pull/882/checks?check_run_id=3933525663 :
This is unexpected because the artifact is used here:
java-pubsub/.kokoro/dependencies.sh Line 61 in 1188d19
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chanseokoh This is the strange behavior of Maven dependency plugin. I appreciate your help!
@@ -61,7 +61,7 @@ | |||
<dependency> | |||
<groupId>com.google.cloud</groupId> | |||
<artifactId>google-cloud-shared-dependencies</artifactId> | |||
<version>2.3.0</version> | |||
<version>2.4.0</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before declaring google-auth-library-oauth2-http, this failed: package com.google.auth.oauth2 does not exist
#882 (comment)
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
🤖 I have created a release \*beep\* \*boop\* --- ### [1.114.7](https://www.github.com/googleapis/java-pubsub/compare/v1.114.6...v1.114.7) (2021-10-19) ### Dependencies * update dependency com.google.cloud:google-cloud-core to v2.1.8 ([#877](https://www.github.com/googleapis/java-pubsub/issues/877)) ([c76329b](https://www.github.com/googleapis/java-pubsub/commit/c76329b06f2f620662f4fe4ffefa897daea8703b)) * update dependency com.google.cloud:google-cloud-core to v2.2.0 ([#881](https://www.github.com/googleapis/java-pubsub/issues/881)) ([1eb4a1f](https://www.github.com/googleapis/java-pubsub/commit/1eb4a1f0a7d318b88cd04f4aefd3191f289e8a0f)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.4.0 ([#882](https://www.github.com/googleapis/java-pubsub/issues/882)) ([2c367bb](https://www.github.com/googleapis/java-pubsub/commit/2c367bb22860cbbfa57fca70a436919ac6aa8084)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This PR contains the following updates:
2.3.0
->2.4.0
Release Notes
googleapis/java-shared-dependencies
v2.4.0
Compare Source
Dependencies
Configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.